tools/gypv8sh.py - Issue 362303002: Also pipe stderr git gypv8sh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gypv8sh.py

Issue 362303002: Also pipe stderr git gypv8sh (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gypv8sh.py

diff --git a/tools/gypv8sh.py b/tools/gypv8sh.py

index cb98f4cb6b88101451e0857fc776d9f2ba21fc1e..8245f5b276ccce7a8746e592f48602a17c227e63 100755

--- a/tools/gypv8sh.py

+++ b/tools/gypv8sh.py

@@ -44,7 +44,8 @@ def main ():

print cmd

if not opts.impotent:

try:

- p = subprocess.Popen(cmd, stdout=subprocess.PIPE, bufsize=0)

+ p = subprocess.Popen(

+ cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, bufsize=0)

out, err = p.communicate()

if p.returncode:

raise Exception('Failed to run d8', out, err)

« no previous file with comments | « no previous file | no next file » | no next file with comments »