Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Side by Side Diff: Source/devtools/front_end/ui/Checkbox.js

Issue 362273002: DevTools: Reduce code via using document.createElementWithClass and document.createChild. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All Rights Reserved. 2 * Copyright (C) 2010 Google Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 13 matching lines...) Expand all
24 */ 24 */
25 25
26 /** 26 /**
27 * @constructor 27 * @constructor
28 * @param {string} label 28 * @param {string} label
29 * @param {string} className 29 * @param {string} className
30 * @param {string=} tooltip 30 * @param {string=} tooltip
31 */ 31 */
32 WebInspector.Checkbox = function(label, className, tooltip) 32 WebInspector.Checkbox = function(label, className, tooltip)
33 { 33 {
34 this.element = document.createElement('label'); 34 this.element = document.createElementWithClass("label", className);
35 this._inputElement = document.createElement('input'); 35 this._inputElement = this.element.createChild("input");
36 this._inputElement.type = "checkbox"; 36 this._inputElement.type = "checkbox";
37 37 this.element.createTextChild(label);
38 this.element.className = className;
39 this.element.appendChild(this._inputElement);
40 this.element.appendChild(document.createTextNode(label));
41 if (tooltip) 38 if (tooltip)
42 this.element.title = tooltip; 39 this.element.title = tooltip;
43 } 40 }
44 41
45 WebInspector.Checkbox.prototype = { 42 WebInspector.Checkbox.prototype = {
46 set checked(checked) 43 set checked(checked)
47 { 44 {
48 this._inputElement.checked = checked; 45 this._inputElement.checked = checked;
49 }, 46 },
50 47
51 get checked() 48 get checked()
52 { 49 {
53 return this._inputElement.checked; 50 return this._inputElement.checked;
54 }, 51 },
55 52
56 addEventListener: function(listener) 53 addEventListener: function(listener)
57 { 54 {
58 function listenerWrapper(event) 55 function listenerWrapper(event)
59 { 56 {
60 if (listener) 57 if (listener)
61 listener(event); 58 listener(event);
62 event.consume(); 59 event.consume();
63 return true; 60 return true;
64 } 61 }
65 62
66 this._inputElement.addEventListener("click", listenerWrapper, false); 63 this._inputElement.addEventListener("click", listenerWrapper, false);
67 this.element.addEventListener("click", listenerWrapper, false); 64 this.element.addEventListener("click", listenerWrapper, false);
68 } 65 }
69 } 66 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/sources/SourcesView.js ('k') | Source/devtools/front_end/ui/Popover.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698