Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Side by Side Diff: PRESUBMIT.py

Issue 362263002: Add clang-format to presubmit checks (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 '#include? See relevant DEPS file(s) for details and contacts.', 107 '#include? See relevant DEPS file(s) for details and contacts.',
108 warning_descriptions)) 108 warning_descriptions))
109 return results 109 return results
110 110
111 111
112 def _CommonChecks(input_api, output_api): 112 def _CommonChecks(input_api, output_api):
113 """Checks common to both upload and commit.""" 113 """Checks common to both upload and commit."""
114 results = [] 114 results = []
115 results.extend(input_api.canned_checks.CheckOwners( 115 results.extend(input_api.canned_checks.CheckOwners(
116 input_api, output_api, source_file_filter=None)) 116 input_api, output_api, source_file_filter=None))
117 results.extend(input_api.canned_checks.CheckPatchFormatted(
118 input_api, output_api))
117 results.extend(_V8PresubmitChecks(input_api, output_api)) 119 results.extend(_V8PresubmitChecks(input_api, output_api))
118 results.extend(_CheckUnwantedDependencies(input_api, output_api)) 120 results.extend(_CheckUnwantedDependencies(input_api, output_api))
119 return results 121 return results
120 122
121 123
122 def _SkipTreeCheck(input_api, output_api): 124 def _SkipTreeCheck(input_api, output_api):
123 """Check the env var whether we want to skip tree check. 125 """Check the env var whether we want to skip tree check.
124 Only skip if src/version.cc has been updated.""" 126 Only skip if src/version.cc has been updated."""
125 src_version = 'src/version.cc' 127 src_version = 'src/version.cc'
126 FilterFile = lambda file: file.LocalPath() == src_version 128 FilterFile = lambda file: file.LocalPath() == src_version
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 'v8_linux_nosnap_rel': set(['defaulttests']), 171 'v8_linux_nosnap_rel': set(['defaulttests']),
170 'v8_linux_nosnap_dbg': set(['defaulttests']), 172 'v8_linux_nosnap_dbg': set(['defaulttests']),
171 'v8_linux64_rel': set(['defaulttests']), 173 'v8_linux64_rel': set(['defaulttests']),
172 'v8_linux_arm_dbg': set(['defaulttests']), 174 'v8_linux_arm_dbg': set(['defaulttests']),
173 'v8_linux_arm64_rel': set(['defaulttests']), 175 'v8_linux_arm64_rel': set(['defaulttests']),
174 'v8_linux_layout_dbg': set(['defaulttests']), 176 'v8_linux_layout_dbg': set(['defaulttests']),
175 'v8_mac_rel': set(['defaulttests']), 177 'v8_mac_rel': set(['defaulttests']),
176 'v8_win_rel': set(['defaulttests']), 178 'v8_win_rel': set(['defaulttests']),
177 }, 179 },
178 } 180 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698