Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: src/parser.cc

Issue 362243005: Fix: Parser::HandleSourceURLComments was making gcmole unhappy (rightfully). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parser.cc
diff --git a/src/parser.cc b/src/parser.cc
index 3adb6d26cdc1b0e1c73b259dea8e6b9201f21184..7566bc3e34851a992d5cad8dda4b8e22cfd01557 100644
--- a/src/parser.cc
+++ b/src/parser.cc
@@ -3887,12 +3887,13 @@ void Parser::RegisterTargetUse(Label* target, Target* stop) {
void Parser::HandleSourceURLComments() {
if (scanner_.source_url()->length() > 0) {
- info_->script()->set_source_url(
- *scanner_.source_url()->Internalize(isolate()));
+ Handle<String> source_url = scanner_.source_url()->Internalize(isolate());
+ info_->script()->set_source_url(*source_url);
}
if (scanner_.source_mapping_url()->length() > 0) {
- info_->script()->set_source_mapping_url(
- *scanner_.source_mapping_url()->Internalize(isolate()));
+ Handle<String> source_mapping_url =
+ scanner_.source_mapping_url()->Internalize(isolate());
+ info_->script()->set_source_mapping_url(*source_mapping_url);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698