Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Unified Diff: tests/compiler/dart2js/compiler_helper.dart

Issue 362243003: Generate mock libraries and assert that helpers are non-null. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/compiler_helper.dart
diff --git a/tests/compiler/dart2js/compiler_helper.dart b/tests/compiler/dart2js/compiler_helper.dart
index c935ee711ac73bdd3adf4719c2a93471875bbf90..be6ca509708cf4ba8e72d0b6804c709bb5851ce3 100644
--- a/tests/compiler/dart2js/compiler_helper.dart
+++ b/tests/compiler/dart2js/compiler_helper.dart
@@ -47,8 +47,6 @@ export 'mock_compiler.dart';
Future<String> compile(String code,
{String entry: 'main',
- String coreSource: DEFAULT_CORELIB,
- String interceptorsSource: DEFAULT_INTERCEPTORSLIB,
bool enableTypeAssertions: false,
bool minify: false,
bool analyzeAll: false,
@@ -56,11 +54,9 @@ Future<String> compile(String code,
void check(String generated)}) {
MockCompiler compiler = new MockCompiler.internal(
enableTypeAssertions: enableTypeAssertions,
- coreSource: coreSource,
// Type inference does not run when manually
// compiling a method.
disableTypeInference: true,
- interceptorsSource: interceptorsSource,
enableMinification: minify,
disableInlining: disableInlining);
return compiler.init().then((_) {
@@ -93,7 +89,7 @@ Future<String> compile(String code,
MockCompiler compilerFor(String code, Uri uri,
{bool analyzeAll: false,
bool analyzeOnly: false,
- String coreSource: DEFAULT_CORELIB,
+ Map coreSource,
karlklose 2014/07/03 08:31:15 Could you type the map?
Johnni Winther 2014/07/03 09:23:25 Done.
bool disableInlining: true,
bool minify: false,
int expectedErrors,
@@ -111,7 +107,7 @@ MockCompiler compilerFor(String code, Uri uri,
}
Future<String> compileAll(String code,
- {String coreSource: DEFAULT_CORELIB,
+ {Map coreSource,
bool disableInlining: true,
bool minify: false,
int expectedErrors,

Powered by Google App Engine
This is Rietveld 408576698