ServiceWorker: Set provider host document URL for no-cache load.

ServiceWorker: Set provider host document URL for no-cache load.

A no-cache loaded page should still have registration capability. If
the document URL is not set, the registration will fail with "SecurityError".

BUG=392405
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282906

[xiang, 2014-07-02 08:24:13]

PTAL, thanks.

[xiang, 2014-07-02 08:27:43]

On 2014/07/02 08:24:13, xiang wrote:
> PTAL, thanks.

Sorry, forget to add the reviewers.

[michaeln, 2014-07-02 18:40:30]

thnx for finding/fixing this

https://codereview.chromium.org/362183002/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_controllee_request_handler.cc
(left):

https://codereview.chromium.org/362183002/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_controllee_request_handler.cc:100:
provider_host_->SetDocumentUrl(stripped_url);
probably should continue to pass in a stripped_url

https://codereview.chromium.org/362183002/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_controllee_request_handler.cc
(right):

https://codereview.chromium.org/362183002/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_controllee_request_handler.cc:52:
request->load_flags() & net::LOAD_BYPASS_CACHE) {
might make sense to split the BYPASS condition out of this first early exit case
since its really of a different nature and we want to do other stuff in that
case too

if (BYPASS) {
  if (main_load)
    SetDocUrl(SimplifyUrlForRequest(url));
  job_= NULL;
  reuturn NULL;
}

[xiang, 2014-07-11 08:56:20]

On 2014/07/02 18:40:30, michaeln wrote:
> thnx for finding/fixing this
> 
>
https://codereview.chromium.org/362183002/diff/1/content/browser/service_work...
> File
content/browser/service_worker/service_worker_controllee_request_handler.cc
> (left):
> 
>
https://codereview.chromium.org/362183002/diff/1/content/browser/service_work...
>
content/browser/service_worker/service_worker_controllee_request_handler.cc:100:
> provider_host_->SetDocumentUrl(stripped_url);
> probably should continue to pass in a stripped_url
> 
>
https://codereview.chromium.org/362183002/diff/1/content/browser/service_work...
> File
content/browser/service_worker/service_worker_controllee_request_handler.cc
> (right):
> 
>
https://codereview.chromium.org/362183002/diff/1/content/browser/service_work...
>
content/browser/service_worker/service_worker_controllee_request_handler.cc:52:
> request->load_flags() & net::LOAD_BYPASS_CACHE) {
> might make sense to split the BYPASS condition out of this first early exit
case
> since its really of a different nature and we want to do other stuff in that
> case too
> 
> if (BYPASS) {
>   if (main_load)
>     SetDocUrl(SimplifyUrlForRequest(url));
>   job_= NULL;
>   reuturn NULL;
> }

Done.
PTAL, thanks for the review.

[michaeln, 2014-07-11 19:48:54]

lgtm

https://codereview.chromium.org/362183002/diff/20001/content/browser/service_...
File content/browser/service_worker/service_worker_controllee_request_handler.cc
(right):

https://codereview.chromium.org/362183002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_controllee_request_handler.cc:56:
if (is_main_resource_load_ && provider_host_) {
dont think we can get here if !provider_host_ so the test for it can be removed

[xiang, 2014-07-14 00:55:14]

On 2014/07/11 19:48:54, michaeln wrote:
> lgtm
> 
>
https://codereview.chromium.org/362183002/diff/20001/content/browser/service_...
> File
content/browser/service_worker/service_worker_controllee_request_handler.cc
> (right):
> 
>
https://codereview.chromium.org/362183002/diff/20001/content/browser/service_...
>
content/browser/service_worker/service_worker_controllee_request_handler.cc:56:
> if (is_main_resource_load_ && provider_host_) {
> dont think we can get here if !provider_host_ so the test for it can be
removed

Done, thanks.

[xiang, 2014-07-14 00:55:20]

The CQ bit was checked by xiang.long@intel.com

[commit-bot: I haz the power, 2014-07-14 00:56:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xiang.long@intel.com/362183002/40001

[commit-bot: I haz the power, 2014-07-14 06:40:50]

Change committed as 282906