Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 362163004: Timeline: fix 'Range'/Pie Chart overlap when timeline details pan is shrunk (Closed)

Created:
6 years, 5 months ago by caseq
Modified:
6 years, 5 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Timeline: fix 'Range'/Pie Chart overlap when timeline details pan is shrunk BUG=386523 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177383

Patch Set 1 #

Patch Set 2 : moved flex-shrik: to affect flex items, not container #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timelinePanel.css View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
caseq
6 years, 5 months ago (2014-07-02 08:02:00 UTC) #1
vsevik
This doesn't work in split panels vertically mode, because in this case the containing box ...
6 years, 5 months ago (2014-07-02 08:53:37 UTC) #2
caseq
On 2014/07/02 08:53:37, vsevik wrote: > This doesn't work in split panels vertically mode, because ...
6 years, 5 months ago (2014-07-02 09:16:27 UTC) #3
vsevik
lgtm
6 years, 5 months ago (2014-07-02 09:29:51 UTC) #4
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 5 months ago (2014-07-02 09:53:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/362163004/20001
6 years, 5 months ago (2014-07-02 09:54:54 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 13:30:21 UTC) #7
Message was sent while issue was closed. 
Change committed as 177383

Powered by Google App Engine
This is Rietveld 408576698