Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 362123005: Cast: Update simulator tool with more inputs. (Closed)

Created:
6 years, 5 months ago by imcheng
Modified:
6 years, 5 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cast: Update simulator tool with more inputs. Inputs: - directory to libffmpegsumo.so. - network simulation parameters given as a proto. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282496

Patch Set 1 : original patch #

Patch Set 2 : Diff #

Total comments: 6

Patch Set 3 : Addressed comments #

Patch Set 4 : Rebase #

Patch Set 5 : namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -42 lines) Patch
M media/cast/cast_testing.gypi View 1 2 3 2 chunks +17 lines, -0 lines 0 comments Download
A + media/cast/test/proto/BUILD.gn View 1 1 chunk +3 lines, -11 lines 0 comments Download
A media/cast/test/proto/network_simulation_model.proto View 1 1 chunk +27 lines, -0 lines 0 comments Download
M media/cast/test/simulator.cc View 1 2 3 4 9 chunks +110 lines, -31 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
imcheng
PTAL.
6 years, 5 months ago (2014-07-01 21:43:44 UTC) #1
Alpha Left Google
https://codereview.chromium.org/362123005/diff/40001/media/cast/test/simulator.cc File media/cast/test/simulator.cc (right): https://codereview.chromium.org/362123005/diff/40001/media/cast/test/simulator.cc#newcode70 media/cast/test/simulator.cc:70: const char kModelPath[] = "model-path"; nit: Just be "model". ...
6 years, 5 months ago (2014-07-01 21:50:38 UTC) #2
imcheng
https://codereview.chromium.org/362123005/diff/40001/media/cast/test/simulator.cc File media/cast/test/simulator.cc (right): https://codereview.chromium.org/362123005/diff/40001/media/cast/test/simulator.cc#newcode70 media/cast/test/simulator.cc:70: const char kModelPath[] = "model-path"; On 2014/07/01 21:50:37, Alpha ...
6 years, 5 months ago (2014-07-02 00:10:09 UTC) #3
imcheng
Rebased with the submitted simulator patch, PTAL, thanks!
6 years, 5 months ago (2014-07-07 13:44:38 UTC) #4
Alpha Left Google
On 2014/07/07 13:44:38, imcheng1 wrote: > Rebased with the submitted simulator patch, PTAL, thanks! Doesn't ...
6 years, 5 months ago (2014-07-10 06:10:27 UTC) #5
imcheng
Uploaded new patch.
6 years, 5 months ago (2014-07-10 16:50:27 UTC) #6
Alpha Left Google
lgtm
6 years, 5 months ago (2014-07-10 17:12:22 UTC) #7
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 5 months ago (2014-07-10 17:52:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/362123005/100001
6 years, 5 months ago (2014-07-10 17:55:35 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 20:26:59 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 20:37:42 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/29432)
6 years, 5 months ago (2014-07-10 20:37:44 UTC) #12
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 5 months ago (2014-07-10 20:51:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/362123005/120001
6 years, 5 months ago (2014-07-10 20:52:47 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 01:43:33 UTC) #15
Message was sent while issue was closed.
Change committed as 282496

Powered by Google App Engine
This is Rietveld 408576698