Source/modules/serviceworkers/ServiceWorkerContainer.h - Issue 362123003: ServiceWorker: unregister's scope argument should be optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainer.h

Issue 362123003: ServiceWorker: unregister's scope argument should be optional (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Reformated test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/serviceworkers/ServiceWorkerContainer.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerContainer.h b/Source/modules/serviceworkers/ServiceWorkerContainer.h

index d3160a0dc2c5dcb2ad9c813ce570c906dbde07f1..fe3c3eabb508351b347a0cc577d3e964a08bebbf 100644

--- a/Source/modules/serviceworkers/ServiceWorkerContainer.h

+++ b/Source/modules/serviceworkers/ServiceWorkerContainer.h

@@ -73,7 +73,7 @@ public:

blink::WebServiceWorkerProvider* provider() { return m_provider; }

ScriptPromise registerServiceWorker(ScriptState*, const String& pattern, const Dictionary&);

- ScriptPromise unregisterServiceWorker(ScriptState*, const String& scope = String());

+ ScriptPromise unregisterServiceWorker(ScriptState*, const String& scope);

// WebServiceWorkerProviderClient overrides.

virtual void setActive(blink::WebServiceWorker*) OVERRIDE;