Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 362033002: Omnibox: Demote Bookmarks on NTP Fakebox (Closed)

Created:
6 years, 5 months ago by Mark P
Modified:
6 years, 5 months ago
Reviewers:
H Fung, Peter Kasting
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Omnibox: Demote Bookmarks on NTP Fakebox This is how there were supposed to be before someone accidentally renumbered the match types. BUG=390597 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282381

Patch Set 1 #

Patch Set 2 : revise comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/omnibox/omnibox_field_trial.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/autocomplete/autocomplete_match_type.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Mark P
Please take a look, thanks. --mark
6 years, 5 months ago (2014-07-01 17:06:33 UTC) #1
H Fung
lgtm Thanks for finding this.
6 years, 5 months ago (2014-07-01 17:39:39 UTC) #2
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 5 months ago (2014-07-01 17:44:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/362033002/20001
6 years, 5 months ago (2014-07-01 17:45:40 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-01 17:45:41 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-01 17:45:41 UTC) #6
Mark P
Peter, can you approve this? thanks, mark
6 years, 5 months ago (2014-07-01 17:51:23 UTC) #7
Mark P
ping
6 years, 5 months ago (2014-07-09 23:03:22 UTC) #8
Peter Kasting
Sorry, LGTM Feel free to TBR me for this sort of thing.
6 years, 5 months ago (2014-07-09 23:09:56 UTC) #9
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 5 months ago (2014-07-09 23:11:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/362033002/20001
6 years, 5 months ago (2014-07-09 23:11:32 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 02:07:34 UTC) #12
commit-bot: I haz the power
Failed to apply patch for chrome/common/autocomplete_match_type.h: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
6 years, 5 months ago (2014-07-10 02:07:35 UTC) #13
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 5 months ago (2014-07-10 16:20:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/362033002/40001
6 years, 5 months ago (2014-07-10 16:23:39 UTC) #15
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 18:26:53 UTC) #16
Message was sent while issue was closed.
Change committed as 282381

Powered by Google App Engine
This is Rietveld 408576698