Reduce integer divides in GrAllocator

Reduce integer divides in GrAllocator

Committed: https://skia.googlesource.com/skia/+/bce3d6dbb91c3e67f1010556c2b8aaf6d7a49267

[egdaniel, 2014-07-02 13:43:37]

lgtm with minor comments

https://codereview.chromium.org/362023002/diff/40001/src/gpu/GrAllocator.h
File src/gpu/GrAllocator.h (right):

https://codereview.chromium.org/362023002/diff/40001/src/gpu/GrAllocator.h#ne...
src/gpu/GrAllocator.h:30: : fItemSize(itemSize)
do we normally indent the initializer list?

https://codereview.chromium.org/362023002/diff/40001/src/gpu/GrAllocator.h#ne...
src/gpu/GrAllocator.h:299: const T& get() const {
get() is typically used in skia to return a pointer, maybe some other name here?

[bsalomon, 2014-07-02 13:55:04]

https://codereview.chromium.org/362023002/diff/40001/src/gpu/GrAllocator.h
File src/gpu/GrAllocator.h (right):

https://codereview.chromium.org/362023002/diff/40001/src/gpu/GrAllocator.h#ne...
src/gpu/GrAllocator.h:30: : fItemSize(itemSize)
On 2014/07/02 13:43:37, egdaniel wrote:
> do we normally indent the initializer list?

I think so, but I don't like it :). It lines the init list up with the code
which I find hurts readability. But I'll change it.

https://codereview.chromium.org/362023002/diff/40001/src/gpu/GrAllocator.h#ne...
src/gpu/GrAllocator.h:299: const T& get() const {
On 2014/07/02 13:43:37, egdaniel wrote:
> get() is typically used in skia to return a pointer, maybe some other name
here?

Any ideas? I can't think of anything that better that isn't overly verbose.

I suppose this could return a pointer.

[bsalomon, 2014-07-02 14:30:10]

ptal

[egdaniel, 2014-07-02 14:39:15]

lgtm

[bsalomon, 2014-07-02 14:39:46]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-07-02 14:39:57]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/362023002/80001

[commit-bot: I haz the power, 2014-07-02 14:54:46]

Change committed as bce3d6dbb91c3e67f1010556c2b8aaf6d7a49267