Issue 362018: Reverts some useful code accidently removed by CL http://codereview.chromium....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 362018: Reverts some useful code accidently removed by CL http://codereview.chromium.... (Closed)

Created:
11 years, 1 month ago by James Su

Modified:
9 years, 7 months ago

Reviewers:
Daniel Erat, Evan Martin

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Reverts some useful code accidently removed by CL http://codereview.chromium.org/340024/show BUG=12316, 24818 TEST=Clear the omnibox, and paste something into it by middle click, the inline autocomplete shouldn't be triggered. TEST=Input something in the omnibox to trigger inline autocomplete, then press and hold ctrl key and click the text to clear the selection, then release ctrl key, the text in the omnibox shouldn't be changed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31198

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_gtk.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
	M	chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc	View		4 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks for fixing it!

Expand Messages | Collapse Messages