Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 362013002: Poll CanPredictNetworkActionsUI in PrerenderManager::IsEnabled. (Closed)

Created:
6 years, 5 months ago by Bence
Modified:
6 years, 5 months ago
Reviewers:
tburkard
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, davidben+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Poll CanPredictNetworkActionsUI in PrerenderManager::IsEnabled. Poll CanPredictNetworkActionsUI in PrerenderManager::IsEnabled if the preference kNetworkPredictionOptions is set to a value different from its default. Otherwise, assume that the user interface has not been updated, and revert to the previously used mechanism to be consistent with the user interface options. BUG=334602 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/prerender/prerender_manager.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Bence
6 years, 5 months ago (2014-07-01 15:26:46 UTC) #1
Bence
tburkard: PTAL
6 years, 5 months ago (2014-07-07 13:56:23 UTC) #2
tburkard
lgtm
6 years, 5 months ago (2014-07-07 13:59:13 UTC) #3
Bence
The CQ bit was checked by bnc@chromium.org
6 years, 5 months ago (2014-07-07 14:19:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bnc@chromium.org/362013002/1
6 years, 5 months ago (2014-07-07 14:20:41 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-07 14:56:04 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 15:55:05 UTC) #7
Message was sent while issue was closed.
Change committed as 281545

Powered by Google App Engine
This is Rietveld 408576698