Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 361983003: Wait for sweeper threads only if we have to. (Closed)

Created:
6 years, 5 months ago by Hannes Payer (out of office)
Modified:
6 years, 5 months ago
Reviewers:
ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Wait for sweeper threads only if we have to, i.e. if we globally have to finish sweeping or if we have to allocate from a certain space. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22156

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -29 lines) Patch
M src/heap.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 2 1 chunk +6 lines, -7 lines 0 comments Download
M src/mark-compact.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/mark-compact.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M src/spaces.h View 1 2 2 chunks +10 lines, -3 lines 0 comments Download
M src/spaces.cc View 1 2 7 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Hannes Payer (out of office)
6 years, 5 months ago (2014-07-01 14:46:59 UTC) #1
ulan
https://codereview.chromium.org/361983003/diff/1/src/spaces.h File src/spaces.h (right): https://codereview.chromium.org/361983003/diff/1/src/spaces.h#newcode1997 src/spaces.h:1997: bool was_swept_concurrently_; It seems to be uninitialized.
6 years, 5 months ago (2014-07-02 06:45:47 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/361983003/diff/1/src/spaces.h File src/spaces.h (right): https://codereview.chromium.org/361983003/diff/1/src/spaces.h#newcode1997 src/spaces.h:1997: bool was_swept_concurrently_; On 2014/07/02 06:45:47, ulan wrote: > It ...
6 years, 5 months ago (2014-07-02 07:00:52 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/361983003/diff/20001/src/spaces.h File src/spaces.h (right): https://codereview.chromium.org/361983003/diff/20001/src/spaces.h#newcode1993 src/spaces.h:1993: // an non-iterable or iterable heap, respectively. Actually, we ...
6 years, 5 months ago (2014-07-02 07:02:53 UTC) #4
Hannes Payer (out of office)
We cannot have the Space <-> MarkCompactCollector::SweeperType. Can you please have another look?
6 years, 5 months ago (2014-07-02 07:52:38 UTC) #5
ulan
lgtm
6 years, 5 months ago (2014-07-02 08:02:03 UTC) #6
Hannes Payer (out of office)
6 years, 5 months ago (2014-07-02 12:33:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r22156 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698