Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 361963003: Revert "Add msan build option." (r22109) (Closed)

Created:
6 years, 5 months ago by Yang
Modified:
6 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert "Add msan build option." (r22109) Building d8 with msan requires instrumented libc++. Currently the advised way to do this is from a chromium checkout with d8 as target. R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22124

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M Makefile View 1 chunk +1 line, -7 lines 0 comments Download
M build/standalone.gypi View 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 5 months ago (2014-07-01 13:10:45 UTC) #1
Jarin
lgtm
6 years, 5 months ago (2014-07-01 13:20:53 UTC) #2
Yang
6 years, 5 months ago (2014-07-01 13:51:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22124 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698