Source/core/xml/XMLHttpRequest.idl - Issue 361883004: Replace many [TreatReturnedNullStringAs=Null] with nullable DOMString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XMLHttpRequest.idl

Issue 361883004: Replace many [TreatReturnedNullStringAs=Null] with nullable DOMString (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/xml/XMLHttpRequest.idl

diff --git a/Source/core/xml/XMLHttpRequest.idl b/Source/core/xml/XMLHttpRequest.idl

index c69a568af4e1c64b85614c99653863e8ef453904..ad6f01a5b958c90d19055c446cb0aa582ae2d53d 100644

--- a/Source/core/xml/XMLHttpRequest.idl

+++ b/Source/core/xml/XMLHttpRequest.idl

@@ -69,8 +69,8 @@ enum XMLHttpRequestResponseType {

// response

[TreatReturnedNullStringAs=Undefined] DOMString getAllResponseHeaders();

- [TreatReturnedNullStringAs=Null] DOMString getResponseHeader(DOMString header);

- [Custom=Getter, RaisesException=Getter] readonly attribute DOMString responseText; // The custom getter implements TreatReturnedNullStringAs=Null

+ DOMString? getResponseHeader(DOMString header);

+ [Custom=Getter, RaisesException=Getter] readonly attribute DOMString? responseText;

[RaisesException=Getter] readonly attribute Document responseXML;

[RaisesException=Setter] attribute XMLHttpRequestResponseType responseType;

« Source/core/frame/Window.idl ('K') | « Source/core/testing/TypeConversions.idl ('k') | Source/core/xml/XPathNSResolver.idl » ('j') | no next file with comments »