Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: Source/core/dom/Element.idl

Issue 361883004: Replace many [TreatReturnedNullStringAs=Null] with nullable DOMString (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Element.idl
diff --git a/Source/core/dom/Element.idl b/Source/core/dom/Element.idl
index ea697b0f8bd80cd2f2aed214327b766a88a124b5..7593e26bfe8ba3111406ae4d388ea9257ff68645 100644
--- a/Source/core/dom/Element.idl
+++ b/Source/core/dom/Element.idl
@@ -24,9 +24,9 @@
// DOM Level 1 Core
- [TreatReturnedNullStringAs=Null] readonly attribute DOMString tagName;
+ readonly attribute DOMString? tagName;
- [TreatReturnedNullStringAs=Null] DOMString getAttribute(DOMString name);
+ DOMString? getAttribute(DOMString name);
[RaisesException, CustomElementCallbacks] void setAttribute(DOMString name, DOMString value);
[CustomElementCallbacks] void removeAttribute(DOMString name);
[MeasureAs=ElementGetAttributeNode] Attr getAttributeNode([Default=Undefined] optional DOMString name); // Removed from DOM4.
@@ -39,7 +39,7 @@
// DOM Level 2 Core
- [TreatReturnedNullStringAs=Null] DOMString getAttributeNS([TreatNullAs=NullString] DOMString namespaceURI, DOMString localName);
+ DOMString? getAttributeNS([TreatNullAs=NullString] DOMString namespaceURI, DOMString localName);
[RaisesException, CustomElementCallbacks] void setAttributeNS([TreatNullAs=NullString] DOMString namespaceURI, DOMString qualifiedName, DOMString value);
[CustomElementCallbacks] void removeAttributeNS([TreatNullAs=NullString] DOMString namespaceURI, DOMString localName);
HTMLCollection getElementsByTagNameNS([TreatNullAs=NullString] DOMString namespaceURI, DOMString localName);
@@ -53,9 +53,9 @@
// DOM4
[Reflect] attribute DOMString id;
- [TreatReturnedNullStringAs=Null] readonly attribute DOMString namespaceURI;
- [TreatReturnedNullStringAs=Null, TreatNullAs=NullString, RaisesException=Setter] attribute DOMString prefix;
- [TreatReturnedNullStringAs=Null] readonly attribute DOMString localName;
+ readonly attribute DOMString? namespaceURI;
+ [RaisesException=Setter] attribute DOMString? prefix;
+ readonly attribute DOMString? localName;
[RaisesException] boolean matches(DOMString selectors);

Powered by Google App Engine
This is Rietveld 408576698