Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: Source/core/dom/Attr.idl

Issue 361883004: Replace many [TreatReturnedNullStringAs=Null] with nullable DOMString (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Attr.idl
diff --git a/Source/core/dom/Attr.idl b/Source/core/dom/Attr.idl
index 9c1fb6c82a50e9a111cd16f0596fe6b54c0816b2..5c22a7986f1d548b34025d1e5656b780dc6d85b0 100644
--- a/Source/core/dom/Attr.idl
+++ b/Source/core/dom/Attr.idl
@@ -22,13 +22,13 @@ interface Attr : Node {
// DOM Level 1
- [TreatReturnedNullStringAs=Null] readonly attribute DOMString name;
+ readonly attribute DOMString? name;
[MeasureAs=AttributeSpecified] readonly attribute boolean specified;
- [ImplementedAs=valueForBindings, TreatReturnedNullStringAs=Null, TreatNullAs=NullString, CustomElementCallbacks] attribute DOMString value;
- [TreatReturnedNullStringAs=Null, TreatNullAs=NullString, DeprecateAs=AttrNodeValue, ImplementedAs=valueForBindings] attribute DOMString nodeValue;
- [TreatReturnedNullStringAs=Null, TreatNullAs=NullString, DeprecateAs=AttrTextContent, ImplementedAs=valueForBindings] attribute DOMString textContent;
+ [ImplementedAs=valueForBindings, CustomElementCallbacks] attribute DOMString? value;
+ [DeprecateAs=AttrNodeValue, ImplementedAs=valueForBindings] attribute DOMString? nodeValue;
+ [DeprecateAs=AttrTextContent, ImplementedAs=valueForBindings] attribute DOMString? textContent;
// DOM Level 2
@@ -36,8 +36,8 @@ interface Attr : Node {
// DOM 4
- [TreatReturnedNullStringAs=Null] readonly attribute DOMString prefix;
- [TreatReturnedNullStringAs=Null] readonly attribute DOMString namespaceURI;
- [TreatReturnedNullStringAs=Null] readonly attribute DOMString localName;
+ readonly attribute DOMString? prefix;
+ readonly attribute DOMString? namespaceURI;
+ readonly attribute DOMString? localName;
};

Powered by Google App Engine
This is Rietveld 408576698