Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issue 361873003: DevTools: [Styles] do not add px suffix to line-height properties (Closed)

Created:
6 years, 5 months ago by lushnikov
Modified:
6 years, 5 months ago
Reviewers:
vsevik, apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [Styles] do not add px suffix to line-height properties 'line-height' property is perfectly valid without a unit identifier, so do not force adding "px" suffix if there's none. BUG=387884 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177293

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/sdk/CSSMetadata.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
lushnikov
ptal
6 years, 5 months ago (2014-07-01 07:51:30 UTC) #1
vsevik
lgtm
6 years, 5 months ago (2014-07-01 08:06:23 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 5 months ago (2014-07-01 08:40:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/361873003/1
6 years, 5 months ago (2014-07-01 08:40:48 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-01 09:46:44 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 10:52:12 UTC) #6
Message was sent while issue was closed.
Change committed as 177293

Powered by Google App Engine
This is Rietveld 408576698