Source/bindings/core/v8/V8HiddenValue.h - Issue 361863003: Add a helper for implementing Promise-valued properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8HiddenValue.h

Issue 361863003: Add a helper for implementing Promise-valued properties. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: More feedback. Keeping separate header file for now. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8HiddenValue.h

diff --git a/Source/bindings/core/v8/V8HiddenValue.h b/Source/bindings/core/v8/V8HiddenValue.h

index fdcbec74c53188f5af57eb2fb55e4b5c629e7eec..ab94db249cf11a1a96919dfd6e96fd583c37968a 100644

--- a/Source/bindings/core/v8/V8HiddenValue.h

+++ b/Source/bindings/core/v8/V8HiddenValue.h

@@ -6,6 +6,7 @@

#define V8HiddenValue_h

#include "bindings/core/v8/ScopedPersistent.h"

+#include "bindings/core/v8/ScriptPromiseProperties.h"

#include <v8.h>

namespace WebCore {

@@ -37,7 +38,9 @@ class ScriptWrappable;

V(stringData) \

V(scriptState) \

V(thenableHiddenPromise) \

- V(toStringString)

+ V(toStringString) \

+ SCRIPT_PROMISE_PROPERTIES(V, Promise) \

+ SCRIPT_PROMISE_PROPERTIES(V, Resolver)

class V8HiddenValue {

public: