Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 361823004: Do not include FastMalloc.h in config.h. (Closed)

Created:
6 years, 5 months ago by lgombos
Modified:
6 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Do not include FastMalloc.h in config.h as we no longer redefine new and delete in FastMalloc.h. FastMalloc.h use to include cstddef; this header is still needed globally in blink so now it needs to be included explicitly in config.h (and remove the inclusion of it everywhere else in blink). Not including wtf/WTFExport.h in config.h (indirectly) revealed a bug in NullPtr.h. NullPtr.h now only includes wtf/WTFExport.h conditionally (so that if the compiler supports nullptr does not need to include it). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177271

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M Source/config.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/platform/CheckedInt.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/wtf/FastMalloc.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/wtf/NullPtr.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
lgombos
I noticed your work at https://codereview.chromium.org/345203007, in a way this is a follow-up to that.
6 years, 5 months ago (2014-07-01 02:38:27 UTC) #1
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-01 03:43:49 UTC) #2
abarth-chromium
Ideally, config.h would be empty. We can move a bunch of the feature defines it ...
6 years, 5 months ago (2014-07-01 03:44:25 UTC) #3
lgombos
On 2014/07/01 03:44:25, abarth wrote: > Ideally, config.h would be empty. I think the next ...
6 years, 5 months ago (2014-07-01 03:48:48 UTC) #4
abarth-chromium
On 2014/07/01 at 03:48:48, l.gombos wrote: > I think the next step is to remove ...
6 years, 5 months ago (2014-07-01 03:56:01 UTC) #5
lgombos
The CQ bit was checked by l.gombos@samsung.com
6 years, 5 months ago (2014-07-01 04:11:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/361823004/1
6 years, 5 months ago (2014-07-01 04:11:17 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 04:15:10 UTC) #8
Message was sent while issue was closed.
Change committed as 177271

Powered by Google App Engine
This is Rietveld 408576698