Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 361723002: Have Clang builders build in C++11 mode. (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Have Clang builders build in C++11 mode. This ought to get us a little ahead on the transition. Only minor fixes are needed. The one in MemoryBench is the most interesting: what used to unambiguously be interpreted as concatenating two string literals is now also ambiguously a user-defined literal; adding a space disambiguates. BUG=skia: Committed: https://skia.googlesource.com/skia/+/170e00d6403c40114d6ffb800a5bfab73e0b0f34

Patch Set 1 #

Patch Set 2 : fix? #

Patch Set 3 : try again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M bench/MemoryBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/common_conditions.gypi View 1 2 1 chunk +9 lines, -2 lines 0 comments Download
M gyp/libwebp.gyp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
mtklein
6 years, 5 months ago (2014-06-30 17:49:10 UTC) #1
bungeman-skia
lgtm
6 years, 5 months ago (2014-06-30 18:04:33 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-06-30 18:04:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/361723002/1
6 years, 5 months ago (2014-06-30 18:05:27 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia ...
6 years, 5 months ago (2014-06-30 18:21:47 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 18:29:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/525)
6 years, 5 months ago (2014-06-30 18:29:57 UTC) #7
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-06-30 18:35:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/361723002/20001
6 years, 5 months ago (2014-06-30 18:36:36 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia ...
6 years, 5 months ago (2014-06-30 18:53:37 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 19:06:18 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/527)
6 years, 5 months ago (2014-06-30 19:06:19 UTC) #12
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-06-30 19:15:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/361723002/40001
6 years, 5 months ago (2014-06-30 19:15:55 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 19:33:15 UTC) #15
Message was sent while issue was closed.
Change committed as 170e00d6403c40114d6ffb800a5bfab73e0b0f34

Powered by Google App Engine
This is Rietveld 408576698