Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 361693004: Remove make-css-file-arrays.pl. (Closed)

Created:
6 years, 5 months ago by tkent
Modified:
6 years, 5 months ago
Reviewers:
haraken, brettw
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, aandrey+blink_chromium.org, rune+blink, caseq+blink_chromium.org, malch+blink_chromium.org, blink-reviews-css, yurys+blink_chromium.org, dglazkov+blink, jchaffraix+rendering, devtools-reviews_chromium.org, pdr., rwlbuis, loislo+blink_chromium.org, zoltan1, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, blink-reviews-rendering, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, sergeyv+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove make-css-file-arrays.pl. Use make-file-arrays.py instead. Now we don't need perl to build Blink. We still need perl to run layout tests. - We remove action_useragentstylesheets.py wrapper too. - make-file-arrays.py supports file names including '-' for view-source.css. - make-file-arrays.py removes unnecessary EOL characters in order to make the behaivor same as make-css-file-arrays.pl. - Change generated variable names for consistency. BUG=347863 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177264

Patch Set 1 : #

Total comments: 9

Patch Set 2 : \s consistentcy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -266 lines) Patch
D Source/build/scripts/action_useragentstylesheets.py View 1 chunk +0 lines, -123 lines 0 comments Download
M Source/build/scripts/make-file-arrays.py View 1 2 chunks +7 lines, -5 lines 0 comments Download
M Source/build/scripts/scripts.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/build/scripts/scripts.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/BUILD.gn View 1 2 chunks +6 lines, -12 lines 0 comments Download
M Source/core/core_generated.gyp View 2 chunks +6 lines, -7 lines 0 comments Download
M Source/core/css/CSSDefaultStyleSheets.cpp View 1 9 chunks +10 lines, -11 lines 0 comments Download
D Source/core/css/make-css-file-arrays.pl View 1 chunk +0 lines, -88 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumAndroid.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumDefault.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.mm View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumSkia.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tkent
brettw, jamesr, This contains GN changes. Would you review this please? https://codereview.chromium.org/361693004/diff/20001/Source/build/scripts/make-file-arrays.py File Source/build/scripts/make-file-arrays.py (left): ...
6 years, 5 months ago (2014-06-30 07:09:17 UTC) #1
brettw
.gn LGTM
6 years, 5 months ago (2014-06-30 16:47:50 UTC) #2
tkent
Brett, thank you!. haraken, would you review non-GN part?
6 years, 5 months ago (2014-06-30 23:26:42 UTC) #3
haraken
LGTM with nits. https://codereview.chromium.org/361693004/diff/20001/Source/build/scripts/make-file-arrays.py File Source/build/scripts/make-file-arrays.py (right): https://codereview.chromium.org/361693004/diff/20001/Source/build/scripts/make-file-arrays.py#newcode70 Source/build/scripts/make-file-arrays.py:70: trailing_space = re.compile(r'[ \t]+$', re.MULTILINE) Shall ...
6 years, 5 months ago (2014-07-01 00:47:46 UTC) #4
tkent
Thank you for review. https://codereview.chromium.org/361693004/diff/20001/Source/core/BUILD.gn File Source/core/BUILD.gn (right): https://codereview.chromium.org/361693004/diff/20001/Source/core/BUILD.gn#newcode1037 Source/core/BUILD.gn:1037: script = "../build/scripts/make-file-arrays.py" On 2014/07/01 ...
6 years, 5 months ago (2014-07-01 00:52:49 UTC) #5
haraken
https://codereview.chromium.org/361693004/diff/20001/Source/core/BUILD.gn File Source/core/BUILD.gn (right): https://codereview.chromium.org/361693004/diff/20001/Source/core/BUILD.gn#newcode1037 Source/core/BUILD.gn:1037: script = "../build/scripts/make-file-arrays.py" On 2014/07/01 00:52:49, tkent wrote: > ...
6 years, 5 months ago (2014-07-01 01:00:00 UTC) #6
tkent
https://codereview.chromium.org/361693004/diff/20001/Source/build/scripts/make-file-arrays.py File Source/build/scripts/make-file-arrays.py (right): https://codereview.chromium.org/361693004/diff/20001/Source/build/scripts/make-file-arrays.py#newcode70 Source/build/scripts/make-file-arrays.py:70: trailing_space = re.compile(r'[ \t]+$', re.MULTILINE) On 2014/07/01 00:47:45, haraken ...
6 years, 5 months ago (2014-07-01 01:05:46 UTC) #7
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 5 months ago (2014-07-01 01:07:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/361693004/40001
6 years, 5 months ago (2014-07-01 01:08:15 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 02:42:28 UTC) #10
Message was sent while issue was closed.
Change committed as 177264

Powered by Google App Engine
This is Rietveld 408576698