LayoutTests/fast/dom/Range/getClientRects-leading-trailing-whitespaces.html - Issue 361683002: Make LayoutText::absoluteQuadsForRange to consider leading/trailing whitespaces

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Range/getClientRects-leading-trailing-whitespaces.html

Issue 361683002: Make LayoutText::absoluteQuadsForRange to consider leading/trailing whitespaces (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-18T16:38:30 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <div id="target"> abc </div>

	5 <div id="log"></div>

	6 <script>

	7 var target = document.getElementById('target').firstChild;

	8 var results = [0, 1, 2, 3, 4, 5, 6, 7, 8].map(function(offset) {
	eae 2015/08/18 16:14:45 Please avoid doing data driven tests, while compac Please avoid doing data driven tests, while compact it makes it harder to understand what the test is supposed to test and makes debugging much trickier than it needs to be. yosin_UTC9 2015/08/19 06:08:55 Done. Show quoted text On 2015/08/18 16:14:45, eae wrote: > Please avoid doing data driven tests, while compact it makes it harder to > understand what the test is supposed to test and makes debugging much trickier > than it needs to be. Done.
	9 var range = document.createRange();

	10 range.setStart(target, offset);

	11 var rects = range.getClientRects();

	12 return rects.length ? rects[0].left : 'no rects';

	13 });

	14 test(function() {

	15 assert_equals(results[0], results[3], '0');

	16 assert_equals(results[1], results[3], '1');

	17 assert_equals(results[2], results[3], '2');

	18 }, 'leading whitespaces');

	19

	20 test(function() {

	21 assert_greater_than(results[6], results[5], '6');

	22 assert_equals(results[7], results[6], '7');

	23 assert_equals(results[8], results[6], '8');

	24 }, 'trailing whitespaces');

	25 </script>

OLD	NEW

« no previous file with comments | « no previous file | Source/core/layout/LayoutText.cpp » ('j') | Source/core/layout/LayoutText.cpp » ('J')