Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Unified Diff: Source/web/tests/RenderTableCellTest.cpp

Issue 361633003: Move the table death tests to core/rendering/ (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderTableRowTest.cpp ('k') | Source/web/tests/RenderTableRowTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/RenderTableCellTest.cpp
diff --git a/Source/web/tests/RenderTableCellTest.cpp b/Source/web/tests/RenderTableCellTest.cpp
deleted file mode 100644
index a0eeadcee11f6c8e521802b56e29cb36377fde83..0000000000000000000000000000000000000000
--- a/Source/web/tests/RenderTableCellTest.cpp
+++ /dev/null
@@ -1,114 +0,0 @@
-/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- *
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
- * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
- * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-
-#include "core/rendering/RenderTableCell.h"
-
-#include "core/frame/LocalFrame.h"
-#include "public/web/WebFrame.h"
-#include "public/web/WebView.h"
-#include "web/WebLocalFrameImpl.h"
-#include "web/tests/FrameTestHelpers.h"
-
-#include <gtest/gtest.h>
-
-using namespace blink;
-
-namespace WebCore {
-
-namespace {
-
-class RenderTableCellDeathTest : public testing::Test {
-protected:
- static void SetUpTestCase()
- {
- // It's unfortunate that we have to get the whole browser stack to test one RenderObject
- // but the code needs it.
- s_webViewHelper = new FrameTestHelpers::WebViewHelper();
- s_webViewHelper->initializeAndLoad("about:blank");
- s_webViewHelper->webView()->setFocus(true);
- }
-
- static void TearDownTestCase()
- {
- delete s_webViewHelper;
- }
-
- static Document* document()
- {
- return toWebLocalFrameImpl(s_webViewHelper->webView()->mainFrame())->frame()->document();
- }
-
- virtual void SetUp()
- {
- m_cell = RenderTableCell::createAnonymous(document());
- }
-
- virtual void TearDown()
- {
- m_cell->destroy();
- }
-
- RenderTableCell* m_cell;
-
-private:
- static FrameTestHelpers::WebViewHelper* s_webViewHelper;
-};
-
-FrameTestHelpers::WebViewHelper* RenderTableCellDeathTest::s_webViewHelper = 0;
-
-TEST_F(RenderTableCellDeathTest, CanSetColumn)
-{
- static const unsigned columnIndex = 10;
- m_cell->setCol(columnIndex);
- EXPECT_EQ(columnIndex, m_cell->col());
-}
-
-TEST_F(RenderTableCellDeathTest, CanSetColumnToMaxColumnIndex)
-{
- m_cell->setCol(maxColumnIndex);
- EXPECT_EQ(maxColumnIndex, m_cell->col());
-}
-
-// FIXME: Re-enable these tests once ASSERT_DEATH is supported for Android.
-// See: https://bugs.webkit.org/show_bug.cgi?id=74089
-#if !OS(ANDROID)
-
-TEST_F(RenderTableCellDeathTest, CrashIfColumnOverflowOnSetting)
-{
- ASSERT_DEATH(m_cell->setCol(maxColumnIndex + 1), "");
-}
-
-TEST_F(RenderTableCellDeathTest, CrashIfSettingUnsetColumnIndex)
-{
- ASSERT_DEATH(m_cell->setCol(unsetColumnIndex), "");
-}
-
-#endif
-
-}
-
-} // namespace WebCore
« no previous file with comments | « Source/core/rendering/RenderTableRowTest.cpp ('k') | Source/web/tests/RenderTableRowTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698