Issue 361633003: Move the table death tests to core/rendering/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 361633003: Move the table death tests to core/rendering/ (Closed)

Created:
6 years, 5 months ago by Julien - ping for review

Modified:
6 years, 5 months ago

Reviewers:
esprehn, jochen (gone - plz use gerrit), abarth-chromium

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Move the table death tests to core/rendering/ Those tests were added to web/tests as this was the only way to test them at the time. They can now use DummyPageHolder and be moved to core/rendering where they belong. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177177

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -290 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	Source/core/rendering/RenderTableCellTest.cpp	View	3 chunks	+4 lines, -30 lines	0 comments	Download
A +	Source/core/rendering/RenderTableRowTest.cpp	View	3 chunks	+4 lines, -30 lines	0 comments	Download
D	Source/web/tests/RenderTableCellTest.cpp	View	1 chunk	+0 lines, -114 lines	0 comments	Download
D	Source/web/tests/RenderTableRowTest.cpp	View	1 chunk	+0 lines, -114 lines	0 comments	Download
M	Source/web/web.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Julien - ping for review

Unit tests move to core/rendering (those didn't really belong in web/tests but that was the ...

6 years, 5 months ago (2014-06-29 02:45:52 UTC) #1

Julien - ping for review

The CQ bit was checked by jchaffraix@chromium.org

6 years, 5 months ago (2014-06-30 01:51:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/361633003/1

6 years, 5 months ago (2014-06-30 01:52:04 UTC) #4

Message was sent while issue was closed.

Change committed as 177177

Expand Messages | Collapse Messages