Source/core/accessibility/AXMediaControls.cpp - Issue 361563003: Remove unneeded and incorrect static_cast in AXMediaControlsContainer::controllingVideoElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AXMediaControls.cpp

Issue 361563003: Remove unneeded and incorrect static_cast in AXMediaControlsContainer::controllingVideoElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/accessibility/AXMediaControls.cpp

diff --git a/Source/core/accessibility/AXMediaControls.cpp b/Source/core/accessibility/AXMediaControls.cpp

index e445b5409a0cdc467165c704312497d7af60cdbb..a4b795f9e01ab69f9e90d87ed2aad592983960a2 100644

--- a/Source/core/accessibility/AXMediaControls.cpp

+++ b/Source/core/accessibility/AXMediaControls.cpp

@@ -211,7 +211,7 @@ bool AXMediaControlsContainer::controllingVideoElement() const

if (!m_renderer->node())

return true;

- MediaControlTimeDisplayElement* element = static_cast<MediaControlTimeDisplayElement*>(m_renderer->node());

+ MediaControlDivElement* element = static_cast<MediaControlDivElement*>(m_renderer->node());

inferno 2014/07/02 15:49:17 Why do we need a static_cast at all, why not just

return isHTMLVideoElement(toParentMediaElement(element));

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »