Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 361563003: Remove unneeded and incorrect static_cast in AXMediaControlsContainer::controllingVideoElement (Closed)

Created:
6 years, 5 months ago by byoungyoung
Modified:
6 years, 5 months ago
Reviewers:
dmazzoni, aarya, inferno
CC:
blink-reviews, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

There would be no functional changes or performance impacts from this fix, but this can avoid potential misuses and UBsan's bad-casting reports. BUG=280225 R=dmazzoni@chromium.org,inferno@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177407

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed static_cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/core/accessibility/AXMediaControls.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
inferno
Dominic, since this is accessibility related, can you please this.
6 years, 5 months ago (2014-07-02 03:58:34 UTC) #1
inferno
On 2014/07/02 03:58:34, inferno wrote: > Dominic, since this is accessibility related, can you please ...
6 years, 5 months ago (2014-07-02 03:58:48 UTC) #2
inferno
not lgtm https://codereview.chromium.org/361563003/diff/1/Source/core/accessibility/AXMediaControls.cpp File Source/core/accessibility/AXMediaControls.cpp (right): https://codereview.chromium.org/361563003/diff/1/Source/core/accessibility/AXMediaControls.cpp#newcode214 Source/core/accessibility/AXMediaControls.cpp:214: MediaControlDivElement* element = static_cast<MediaControlDivElement*>(m_renderer->node()); Why do we ...
6 years, 5 months ago (2014-07-02 15:49:17 UTC) #3
aarya
lgtm
6 years, 5 months ago (2014-07-02 16:25:10 UTC) #4
inferno
lgtm lgtiming from the chromium account.
6 years, 5 months ago (2014-07-02 16:25:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/byoungyoung@chromium.org/361563003/10001
6 years, 5 months ago (2014-07-02 16:25:50 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 17:46:44 UTC) #7
Message was sent while issue was closed.
Change committed as 177407

Powered by Google App Engine
This is Rietveld 408576698