fpdfsdk/src/fpdf_ext.cpp - Issue 361553002: Remove "this==NULL" and adjust corresponding callers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdf_ext.cpp

Issue 361553002: Remove "this==NULL" and adjust corresponding callers (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: fix if check warning Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fpdf_ext.cpp

diff --git a/fpdfsdk/src/fpdf_ext.cpp b/fpdfsdk/src/fpdf_ext.cpp

index 916cb2069cdd11bdbe5c5d9de8e59668bec1e9cc..93f6e187da60295dfd7137160b0a962dbde1befa 100644

--- a/fpdfsdk/src/fpdf_ext.cpp

+++ b/fpdfsdk/src/fpdf_ext.cpp

@@ -172,15 +172,15 @@ void CheckUnSupportError(CPDF_Document * pDoc, FX_DWORD err_code)

if(pRootDict->KeyExist("Names"))

{

CPDF_Dictionary* pNameDict = pRootDict->GetDict("Names");

- if(pNameDict->KeyExist("EmbeddedFiles"))

+ if (pNameDict && pNameDict->KeyExist("EmbeddedFiles"))

{

FPDF_UnSupportError(FPDF_UNSP_DOC_ATTACHMENT);

return;

}

- else if(pNameDict->KeyExist("JavaScript"))

+ else if (pNameDict && pNameDict->KeyExist("JavaScript"))

{

CPDF_Dictionary* pJSDict = pNameDict->GetDict("JavaScript");

- CPDF_Array * pArray = pJSDict->GetArray("Names");

+ CPDF_Array * pArray = pJSDict ? pJSDict->GetArray("Names") : NULL;

if (pArray) {

int nCount = pArray->GetCount();

for(int i=0; i<nCount; i++)

« no previous file with comments | « fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp ('k') | fpdfsdk/src/fpdf_transformpage.cpp » ('j') | no next file with comments »