core/src/fpdftext/fpdf_text_int.cpp - Issue 361553002: Remove "this==NULL" and adjust corresponding callers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdftext/fpdf_text_int.cpp

Issue 361553002: Remove "this==NULL" and adjust corresponding callers (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: fix if check warning Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdftext/fpdf_text_int.cpp

diff --git a/core/src/fpdftext/fpdf_text_int.cpp b/core/src/fpdftext/fpdf_text_int.cpp

index 6baf6ad339824ca2b8fe84cea61efd079f3b4580..873657595218019d6e55d87595b1dd98a17dc5fd 100644

--- a/core/src/fpdftext/fpdf_text_int.cpp

+++ b/core/src/fpdftext/fpdf_text_int.cpp

@@ -1442,7 +1442,7 @@ FX_INT32 CPDF_TextPage::PreMarkedContent(PDFTEXT_Obj Obj)

CPDF_ContentMarkItem& item = pMarkData->GetItem(n);

CFX_ByteString tagStr = (CFX_ByteString)item.GetName();

pDict = (CPDF_Dictionary*)item.GetParam();

- CPDF_String* temp = (CPDF_String*)pDict->GetElement(FX_BSTRC("ActualText"));

+ CPDF_String* temp = (CPDF_String*)(pDict ? pDict->GetElement(FX_BSTRC("ActualText")) : NULL);

if (temp) {

bExist = TRUE;

actText = temp->GetUnicodeText();

« no previous file with comments | « core/src/fpdfdoc/doc_formfield.cpp ('k') | core/src/fxcrt/fx_xml_parser.cpp » ('j') | no next file with comments »