core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp - Issue 361553002: Remove "this==NULL" and adjust corresponding callers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp

Issue 361553002: Remove "this==NULL" and adjust corresponding callers (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: fix if check warning Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp

index 6c6c0959808031c5c21c329f22174ad17ae3113d..8cb6dc77dc85d531333da8b5507f4aabdc1df039 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp

@@ -97,7 +97,7 @@ FX_BOOL CPDF_ShadingPattern::Load()

if (m_ShadingType != 0) {

return TRUE;

}

- CPDF_Dictionary* pShadingDict = m_pShadingObj->GetDict();

+ CPDF_Dictionary* pShadingDict = m_pShadingObj ? m_pShadingObj->GetDict() : NULL;

if (pShadingDict == NULL) {

return FALSE;

}