core/src/fpdfapi/fpdf_page/fpdf_page_parser_new.cpp - Issue 361553002: Remove "this==NULL" and adjust corresponding callers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_parser_new.cpp

Issue 361553002: Remove "this==NULL" and adjust corresponding callers (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: fix if check warning Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_parser_new.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_parser_new.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_parser_new.cpp

index 5442f9b4ec1a35679c1c09f0155237c51e969203..24ec7436aa81ee3291a56c10df1bd176a60f5101 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_parser_new.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_parser_new.cpp

@@ -498,9 +498,9 @@ void CPDF_StreamContentParser::EndImageDict()

m_bSameLastDict = TRUE;

}

m_ImageSrcBuf.Clear();

- if (m_pLastCloneImageDict) {

+ if (m_pLastCloneImageDict)

m_pLastCloneImageDict->Release();

- }

m_pLastCloneImageDict = (CPDF_Dictionary*)m_pLastImageDict->Clone();

if (m_pLastCloneImageDict->KeyExist(FX_BSTRC("Filter"))) {

m_WordState = 10;