core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp - Issue 361553002: Remove "this==NULL" and adjust corresponding callers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp

Issue 361553002: Remove "this==NULL" and adjust corresponding callers (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: fix if check warning Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp

index a9d2c4d695cf1f264a30fc7a7ffa1bbd8cebfc46..c152b223c90cfcfbfea924aecc9730d27b4996ee 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp

@@ -485,7 +485,7 @@ CPDF_Pattern* CPDF_DocPageData::GetPattern(CPDF_Object* pPatternObj, FX_BOOL bSh

if (bShading) {

pPattern = FX_NEW CPDF_ShadingPattern(m_pPDFDoc, pPatternObj, bShading, matrix);

} else {

- CPDF_Dictionary* pDict = pPatternObj->GetDict();

+ CPDF_Dictionary* pDict = pPatternObj ? pPatternObj->GetDict() : NULL;

if (pDict) {

int type = pDict->GetInteger(FX_BSTRC("PatternType"));

if (type == 1) {