Remove "this==NULL" and adjust corresponding callers

fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp

Index: fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp
diff --git a/fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp b/fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp
index 0c7cd4855354f00f4e818a4ff326f2e78e3b9c78..c9392debf1d011796e626bd99d097978e4a7fd78 100644
--- a/fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp
+++ b/fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp
@@ -239,14 +239,16 @@ CPDF_Font* CBA_FontMap::GetAnnotDefaultFont(CFX_ByteString &sAlias)
 	}
 	
 	CFX_ByteString sDA;
-	
-	sDA = FPDF_GetFieldAttr(m_pAnnotDict, "DA")->GetString();
+	CPDF_Object* pObj;
+	if ( pObj = FPDF_GetFieldAttr(m_pAnnotDict, "DA"))

[Nico, 2014/06/29 20:07:37]

I patched in your change to check that it fixes all this/NULL-related warnings.
It does, but this line adds a new warning:

../../third_party/pdfium/fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp:243:12:
warning: using the result of an assignment as a condition without parentheses
[-Wparentheses]
        if ( pObj = FPDF_GetFieldAttr(m_pAnnotDict, "DA"))
             ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/pdfium/fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp:243:12:
note: place parentheses around the assignment to silence this warning
        if ( pObj = FPDF_GetFieldAttr(m_pAnnotDict, "DA"))
                  ^
             (                                           )
../../third_party/pdfium/fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp:243:12:
note: use '==' to turn this assignment into an equality comparison
        if ( pObj = FPDF_GetFieldAttr(m_pAnnotDict, "DA"))
                  ^
                  ==
1 warning generated.

Please write this as `if ((pObj = FPDF_GetFieldAttr(m_pAnnotDict, "DA")))`.

Thanks!

[Bo Xu, 2014/06/30 00:31:59]

Done

+		sDA = pObj->GetString();
 
 	if (bWidget)
 	{
 		if (sDA.IsEmpty())
 		{
-			sDA = FPDF_GetFieldAttr(pAcroFormDict, "DA")->GetString();	
+			pObj = FPDF_GetFieldAttr(pAcroFormDict, "DA");
+			sDA = pObj ? pObj->GetString() : CFX_ByteString();
 		}
 	}