Remove "this==NULL" and adjust corresponding callers

fpdfsdk/src/fpdfeditpage.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 // #include "x:/pdf/fpdfapi5/include/fpdfapi.h"
 #include "../include/fsdk_define.h"
 #include "../include/fpdfedit.h"
 
@@ skipping 84 matching lines @@
         CPDF_Page* pPage = FX_NEW CPDF_Page;
         pPage->Load(pDoc,pPageDict);
         pPage->ParseContent();
 
         return pPage;
 }
 
 DLLEXPORT int STDCALL FPDFPage_GetRotation(FPDF_PAGE page)
 {
         CPDF_Page* pPage = (CPDF_Page*)page;
-        if (!pPage || !pPage->m_pFormDict || !pPage->m_pFormDict->KeyExist("Type")
+        if (!pPage || !pPage->m_pFormDict || !pPage->m_pFormDict->KeyExist("Type") || !pPage->m_pFormDict->GetElement("Type")->GetDirect()
                 || pPage->m_pFormDict->GetElement("Type")->GetDirect()->GetString().Compare("Page"))
         {
                 return -1;
         }
         CPDF_Dictionary* pDict = pPage->m_pFormDict;
 
         int rotate = 0;
         if(pDict != NULL)
         {
-                if(pDict->KeyExist("Rotate"))
-                        rotate = pDict->GetElement("Rotate")->GetDirect()->GetInteger() / 90;
+                if (pDict->KeyExist("Rotate"))
+                        rotate = pDict->GetElement("Rotate")->GetDirect()? pDict->GetElement("Rotate")->GetDirect()->GetInteger() / 90 : 0;
                 else
                 {
                         if(pDict->KeyExist("Parent"))
                         {
                                 CPDF_Dictionary* pPages = (CPDF_Dictionary*)pDict->GetElement("Parent")->GetDirect();
                                 while(pPages)
                                 {
                                         if(pPages->KeyExist("Rotate"))
                                         {
-                                                rotate = pPages->GetElement("Rotate")->GetDirect()->GetInteger() / 90;
+                                                rotate = pPages->GetElement("Rotate")->GetDirect()? pPages->GetElement("Rotate")->GetDirect()->GetInteger() / 90 : 0;
                                                 break;
                                         }
                                         else if(pPages->KeyExist("Parent"))
                                                 pPages = (CPDF_Dictionary*)pPages->GetElement("Parent")->GetDirect();
                                         else break;
                                 }
                         }
                 }
         }
         else
         {
                 return -1;
         }
         
         return rotate;
 }
 
 DLLEXPORT void STDCALL FPDFPage_InsertObject(FPDF_PAGE page, FPDF_PAGEOBJECT page_obj)
 {
         CPDF_Page* pPage = (CPDF_Page*)page;
-        if (!pPage || !pPage->m_pFormDict || !pPage->m_pFormDict->KeyExist("Type")
+        if (!pPage || !pPage->m_pFormDict || !pPage->m_pFormDict->KeyExist("Type") || !pPage->m_pFormDict->GetElement("Type")->GetDirect()
                 || pPage->m_pFormDict->GetElement("Type")->GetDirect()->GetString().Compare("Page"))
         {
                 return;
         }
         CPDF_PageObject* pPageObj = (CPDF_PageObject*)page_obj;
         if(pPageObj == NULL)
                 return;
         FX_POSITION LastPersition = pPage->GetLastObjectPosition();
 
         pPage->InsertObject(LastPersition, pPageObj);
@@ skipping 34 matching lines @@
         }
 
         //      pPage->ParseContent();
         //pPage->GenerateContent();
 
 }
 
 DLLEXPORT int STDCALL FPDFPage_CountObject(FPDF_PAGE page)
 {
         CPDF_Page* pPage = (CPDF_Page*)page;
-        if (!pPage || !pPage->m_pFormDict || !pPage->m_pFormDict->KeyExist("Type")
+        if (!pPage || !pPage->m_pFormDict || !pPage->m_pFormDict->KeyExist("Type") || !pPage->m_pFormDict->GetElement("Type")->GetDirect()
                 || pPage->m_pFormDict->GetElement("Type")->GetDirect()->GetString().Compare("Page"))
         {
                 return -1;
         }
         return pPage->CountObjects();
 //      return 0;
 }
 
 DLLEXPORT FPDF_PAGEOBJECT STDCALL FPDFPage_GetObject(FPDF_PAGE page, int index)
 {
@@ skipping 43 matching lines @@
                         return TRUE;
                 if(pFormObj->m_pForm && (!(pFormObj->m_pForm->m_Transparency & PDFTRANS_ISOLATED) && (pFormObj->m_pForm->m_Transparency & PDFTRANS_GROUP)))
                         return TRUE;
         }
         return FALSE;
 }
 
 DLLEXPORT FPDF_BOOL STDCALL FPDFPage_GenerateContent(FPDF_PAGE page)
 {
         CPDF_Page* pPage = (CPDF_Page*)page;
-        if (!pPage || !pPage->m_pFormDict || !pPage->m_pFormDict->KeyExist("Type")
+        if (!pPage || !pPage->m_pFormDict || !pPage->m_pFormDict->KeyExist("Type") || !pPage->m_pFormDict->GetElement("Type")->GetDirect()
                 || pPage->m_pFormDict->GetElement("Type")->GetDirect()->GetString().Compare("Page"))
         {
                 return FALSE;
         }
         CPDF_PageContentGenerate CG(pPage);
         CG.GenerateContent();
 
         return TRUE;
 }
 
@@ skipping 34 matching lines @@
                 //Transform AP's rectangle
                 //To Do
 
         }
 
 }
 
 DLLEXPORT void STDCALL FPDFPage_SetRotation(FPDF_PAGE page, int rotate)
 {
         CPDF_Page* pPage = (CPDF_Page*)page;
-        if (!pPage || !pPage->m_pFormDict || !pPage->m_pFormDict->KeyExist("Type")
+        if (!pPage || !pPage->m_pFormDict || !pPage->m_pFormDict->KeyExist("Type") || !pPage->m_pFormDict->GetElement("Type")->GetDirect()
                 || pPage->m_pFormDict->GetElement("Type")->GetDirect()->GetString().Compare("Page"))
         {
                 return;
         }
         CPDF_Dictionary* pDict = pPage->m_pFormDict;
         rotate %=4;
 
         pDict->SetAt("Rotate", FX_NEW CPDF_Number(rotate * 90));
 }