Remove "this==NULL" and adjust corresponding callers

core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_page.h"
 #include "../../../include/fpdfapi/fpdf_module.h"
 #include "../../../include/fpdfapi/fpdf_serial.h"
 #include "pageint.h"
@@ skipping 122 matching lines @@
 #endif
 }
 int CPDF_StreamContentParser::GetNextParamPos()
 {
     if (m_ParamCount == PARAM_BUF_SIZE) {
         m_ParamStartPos ++;
         if (m_ParamStartPos == PARAM_BUF_SIZE) {
             m_ParamStartPos = 0;
         }
         if (m_ParamBuf1[m_ParamStartPos].m_Type == 0) {
-            m_ParamBuf1[m_ParamStartPos].m_pObject->Release();
+            if (CPDF_Object* pObject = m_ParamBuf1[m_ParamStartPos].m_pObject)
+                pObject->Release();
         }
         return m_ParamStartPos;
     }
     int index = m_ParamStartPos + m_ParamCount;
     if (index >= PARAM_BUF_SIZE) {
         index -= PARAM_BUF_SIZE;
     }
     m_ParamCount ++;
     return index;
 }
@@ skipping 26 matching lines @@
 {
     int index = GetNextParamPos();
     m_ParamBuf1[index].m_Type = 0;
     m_ParamBuf1[index].m_pObject = pObj;
 }
 void CPDF_StreamContentParser::ClearAllParams()
 {
     FX_DWORD index = m_ParamStartPos;
     for (FX_DWORD i = 0; i < m_ParamCount; i ++) {
         if (m_ParamBuf1[index].m_Type == 0) {
-            m_ParamBuf1[index].m_pObject->Release();
+            if (CPDF_Object* pObject = m_ParamBuf1[index].m_pObject)
+                pObject->Release();
         }
         index ++;
         if (index == PARAM_BUF_SIZE) {
             index = 0;
         }
     }
     m_ParamStartPos = 0;
     m_ParamCount = 0;
 }
 CPDF_Object* CPDF_StreamContentParser::GetObject(FX_DWORD index)
@@ skipping 30 matching lines @@
         return CFX_ByteString();
     }
     int real_index = m_ParamStartPos + m_ParamCount - index - 1;
     if (real_index >= PARAM_BUF_SIZE) {
         real_index -= PARAM_BUF_SIZE;
     }
     _ContentParam& param = m_ParamBuf1[real_index];
     if (param.m_Type == PDFOBJ_NAME) {
         return CFX_ByteString(param.m_Name.m_Buffer, param.m_Name.m_Len);
     }
-    if (param.m_Type == 0) {
+    if (param.m_Type == 0 && param.m_pObject) {
         return param.m_pObject->GetString();
     }
     return CFX_ByteString();
 }
 FX_FLOAT CPDF_StreamContentParser::GetNumber(FX_DWORD index)
 {
     if (index >= m_ParamCount) {
         return 0;
     }
     int real_index = m_ParamStartPos + m_ParamCount - index - 1;
     if (real_index >= PARAM_BUF_SIZE) {
         real_index -= PARAM_BUF_SIZE;
     }
     _ContentParam& param = m_ParamBuf1[real_index];
     if (param.m_Type == PDFOBJ_NUMBER) {
         return param.m_Number.m_bInteger ? (FX_FLOAT)param.m_Number.m_Integer : param.m_Number.m_Float;
     }
-    if (param.m_Type == 0) {
+    if (param.m_Type == 0 && param.m_pObject) {
         return param.m_pObject->GetNumber();
     }
     return 0;
 }
 FX_FLOAT CPDF_StreamContentParser::GetNumber16(FX_DWORD index)
 {
     return GetNumber(index);
 }
 void CPDF_StreamContentParser::SetGraphicStates(CPDF_PageObject* pObj, FX_BOOL bColor, FX_BOOL bText, FX_BOOL bGraph)
 {
@@ skipping 376 matching lines @@
     if (pCS == NULL) {
         return;
     }
     m_pCurStates->m_ColorState.GetModify()->m_StrokeColor.SetColorSpace(pCS);
 }
 void CPDF_StreamContentParser::Handle_SetDash()
 {
     if (m_Options.m_bTextOnly) {
         return;
     }
-    CPDF_Array* pArray = GetObject(1)->GetArray();
+    CPDF_Array* pArray = GetObject(1) ? GetObject(1)->GetArray() : NULL;
     if (pArray == NULL) {
         return;
     }
     m_pCurStates->SetLineDash(pArray, GetNumber(0), 1.0f);
 }
 void CPDF_StreamContentParser::Handle_SetCharWidth()
 {
     m_Type3Data[0] = GetNumber(1);
     m_Type3Data[1] = GetNumber(0);
     m_bColored = TRUE;
@@ skipping 54 matching lines @@
         FX_BOOL bForm;
         if (m_pDocument->IsFormStream(((CPDF_Reference*)pRes)->GetRefObjNum(), bForm) && !bForm) {
             return;
         }
     }
     CPDF_Stream* pXObject = (CPDF_Stream*)FindResourceObj(FX_BSTRC("XObject"), name);
     if (pXObject == NULL || pXObject->GetType() != PDFOBJ_STREAM) {
         m_bResourceMissing = TRUE;
         return;
     }
-    CFX_ByteStringC type = pXObject->GetDict()->GetConstString(FX_BSTRC("Subtype"));
+    CFX_ByteStringC type = pXObject->GetDict() ? pXObject->GetDict()->GetConstString(FX_BSTRC("Subtype")) : CFX_ByteStringC();
     if (type == FX_BSTRC("Image")) {
         if (m_Options.m_bTextOnly) {
             return;
         }
         CPDF_ImageObject* pObj = AddImage(pXObject, NULL, FALSE);
         m_LastImageName = name;
         m_pLastImage = pObj->m_pImage;
     } else if (type == FX_BSTRC("Form")) {
         AddForm(pXObject);
     } else {
@@ skipping 676 matching lines @@
 void CPDF_StreamContentParser::Handle_ShowText()
 {
     CFX_ByteString str = GetString(0);
     if (str.IsEmpty()) {
         return;
     }
     AddTextObject(&str, 0, NULL, 1);
 }
 void CPDF_StreamContentParser::Handle_ShowText_Positioning()
 {
-    CPDF_Array* pArray = GetObject(0)->GetArray();
+    CPDF_Array* pArray = GetObject(0) ? GetObject(0)->GetArray() : NULL;
     if (pArray == NULL) {
         return;
     }
     int n = pArray->GetCount(), nsegs = 0, i;
     for (i = 0; i < n; i ++) {
         CPDF_Object* pObj = pArray->GetElementValue(i);
         if (pObj->GetType() == PDFOBJ_STRING) {
             nsegs ++;
         }
     }
@@ skipping 11 matching lines @@
     for (i = 0; i < n; i ++) {
         CPDF_Object* pObj = pArray->GetElementValue(i);
         if (pObj->GetType() == PDFOBJ_STRING) {
             CFX_ByteString str = pObj->GetString();
             if (str.IsEmpty()) {
                 continue;
             }
             pStrs[iSegment] = str;
             pKerning[iSegment ++] = 0;
         } else {
+            FX_FLOAT num = pObj ? pObj->GetNumber() : 0;
             if (iSegment == 0) {
-                fInitKerning += pObj->GetNumber();
+                fInitKerning += num;
             } else {
-                pKerning[iSegment - 1] += pObj->GetNumber();
+                pKerning[iSegment - 1] += num;
             }
         }
     }
     AddTextObject(pStrs, fInitKerning, pKerning, iSegment);
     FX_DELETE_VECTOR(pStrs, CFX_ByteString, nsegs);
     FX_Free(pKerning);
 }
 void CPDF_StreamContentParser::Handle_SetTextLeading()
 {
     m_pCurStates->m_TextLeading = GetNumber(0);
@@ skipping 198 matching lines @@
                 buf.AppendChar((char)code);
             }
             bFirst = !bFirst;
         }
     }
     if (!bFirst) {
         buf.AppendChar((char)code);
     }
     return buf.GetByteString();
 }