Remove "this==NULL" and adjust corresponding callers

core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_serial.h"
 CFDF_Document::CFDF_Document() : CPDF_IndirectObjects(NULL)
 {
     m_pRootDict = NULL;
@@ skipping 93 matching lines @@
         size_t objnum;
         CPDF_Object* pObj;
         m_IndirectObjs.GetNextAssoc(pos, (FX_LPVOID&)objnum, (FX_LPVOID&)pObj);
         buf << (FX_DWORD)objnum << FX_BSTRC(" 0 obj\r\n") << pObj << FX_BSTRC("\r\nendobj\r\n\r\n");
     }
     buf << FX_BSTRC("trailer\r\n<</Root ") << m_pRootDict->GetObjNum() << FX_BSTRC(" 0 R>>\r\n%%EOF\r\n");
     return TRUE;
 }
 CFX_WideString CFDF_Document::GetWin32Path() const
 {
-    CPDF_Object* pFileSpec = m_pRootDict->GetDict(FX_BSTRC("FDF"))->GetElementValue(FX_BSTRC("F"));
+    CPDF_Dictionary* pDict = m_pRootDict->GetDict(FX_BSTRC("FDF"));

[Nico, 2014/06/28 01:01:07]

is m_pRootDict guaranteed to be not NULL here?

+    CPDF_Object* pFileSpec = pDict ? pDict->GetElementValue(FX_BSTRC("F")) : NULL;
     if (pFileSpec == NULL) {
         return CFX_WideString();
     }
     if (pFileSpec->GetType() == PDFOBJ_STRING) {
         return FPDF_FileSpec_GetWin32Path(m_pRootDict->GetDict(FX_BSTRC("FDF")));
     }
     return FPDF_FileSpec_GetWin32Path(pFileSpec);
 }
 FX_BOOL CFDF_Document::WriteFile(FX_LPCSTR file_path) const
 {
@@ skipping 71 matching lines @@
         wsFileName = pDict->GetUnicodeText(FX_BSTRC("UF"));
         if (wsFileName.IsEmpty()) {
             wsFileName = CFX_WideString::FromLocal(pDict->GetString(FX_BSTRC("F")));
         }
         if (pDict->GetString(FX_BSTRC("FS")) == FX_BSTRC("URL")) {
             return wsFileName;
         }
         if (wsFileName.IsEmpty() && pDict->KeyExist(FX_BSTRC("DOS"))) {
             wsFileName = CFX_WideString::FromLocal(pDict->GetString(FX_BSTRC("DOS")));
         }
-    } else {
+    }
+    else if (!pFileSpec)
+        wsFileName = CFX_WideString();
+    else {
         wsFileName = CFX_WideString::FromLocal(pFileSpec->GetString());
     }
     if (wsFileName[0] != '/') {
         return ChangeSlash(wsFileName);
     }
     if (wsFileName[2] == '/') {
         CFX_WideString result;
         result += wsFileName[1];
         result += ':';
         result += ChangeSlash(((FX_LPCWSTR)wsFileName) + 2);
         return result;
     } else {
         CFX_WideString result;
         result += '\\';
         result += ChangeSlash(wsFileName);
         return result;
     }
 }