Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 361523002: Fix some more problems with windows paths in content verification (Closed)

Created:
6 years, 5 months ago by asargent_no_longer_on_chrome
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix some more problems with windows paths in content verification It turns out that the relative path we generate inside the network stack when requesting chrome://extension urls uses '/' path separators for relative paths, but the in-memory representation of computed_hashes.json and verified_contents.json files ended up with '\' path separators on windows. So we ended up not finding any paths with a subdirectory at request time. I've fixed this by just standardizing on '/' path separators everywhere. BUG=382638 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280473

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -6 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/computed_hashes.cc View 3 chunks +5 lines, -2 lines 0 comments Download
A extensions/browser/computed_hashes_unittest.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M extensions/browser/content_hash_fetcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/verified_contents.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
asargent_no_longer_on_chrome
6 years, 5 months ago (2014-06-27 21:07:02 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years, 5 months ago (2014-06-27 21:21:28 UTC) #2
asargent_no_longer_on_chrome
The CQ bit was checked by asargent@chromium.org
6 years, 5 months ago (2014-06-27 21:41:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/361523002/1
6 years, 5 months ago (2014-06-27 21:44:53 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-06-28 01:08:28 UTC) #5
Message was sent while issue was closed.
Change committed as 280473

Powered by Google App Engine
This is Rietveld 408576698