Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools/gn/ninja_toolchain_writer.cc

Issue 361503003: Rename GN tool's deps to depsformat. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/function_toolchain.cc ('k') | tools/gn/toolchain.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_toolchain_writer.cc
diff --git a/tools/gn/ninja_toolchain_writer.cc b/tools/gn/ninja_toolchain_writer.cc
index 99087c68f2d23221a55cf09eb7ee04056ee58b32..dac5921734c70c9572b3f8ce1c2103fc1680ae1d 100644
--- a/tools/gn/ninja_toolchain_writer.cc
+++ b/tools/gn/ninja_toolchain_writer.cc
@@ -79,13 +79,16 @@ void NinjaToolchainWriter::WriteRules() {
out_ << indent << " " STRINGIZE(name) " = " << tool.name << std::endl;
WRITE_ARG(command);
WRITE_ARG(depfile);
- WRITE_ARG(deps);
WRITE_ARG(description);
WRITE_ARG(pool);
WRITE_ARG(restat);
WRITE_ARG(rspfile);
WRITE_ARG(rspfile_content);
#undef WRITE_ARG
+
+ // Deps is called "depsformat" in GN to avoid confusion with dependencies.
+ if (!tool.depsformat.empty()) \
+ out_ << indent << " deps = " << tool.depsformat << std::endl;
}
out_ << std::endl;
}
« no previous file with comments | « tools/gn/function_toolchain.cc ('k') | tools/gn/toolchain.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698