Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: tools/gn/function_toolchain.cc

Issue 361503003: Rename GN tool's deps to depsformat. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/ninja_toolchain_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_toolchain.cc
diff --git a/tools/gn/function_toolchain.cc b/tools/gn/function_toolchain.cc
index b748f363f091ef7b3d3981a74b7858c00519328a..b3821eca774e0c1a7bf4d0e9ed3ae78fd20550c2 100644
--- a/tools/gn/function_toolchain.cc
+++ b/tools/gn/function_toolchain.cc
@@ -173,9 +173,12 @@ const char kTool_Help[] =
" they work. Don't forget to backslash-escape $ required by Ninja to\n"
" prevent GN from doing variable expansion.\n"
"\n"
- " command, depfile, deps, description, pool, restat, rspfile,\n"
+ " command, depfile, depsformat, description, pool, restat, rspfile,\n"
" rspfile_content\n"
"\n"
+ " (Note that GN uses \"depsformat\" for Ninja's \"deps\" variable to\n"
+ " avoid confusion with dependency lists.)\n"
+ "\n"
" Additionally, lib_prefix and lib_dir_prefix may be used for the link\n"
" tools. These strings will be prepended to the libraries and library\n"
" search directories, respectively, because linkers differ on how to\n"
@@ -236,7 +239,11 @@ Value RunTool(Scope* scope,
Toolchain::Tool t;
if (!ReadString(block_scope, "command", &t.command, err) ||
!ReadString(block_scope, "depfile", &t.depfile, err) ||
- !ReadString(block_scope, "deps", &t.deps, err) ||
+ // TODO(brettw) delete this once we rename "deps" -> "depsformat" in
+ // the toolchain definitions. This will avoid colliding with the
+ // toolchain's "deps" list. For now, accept either.
+ !ReadString(block_scope, "deps", &t.depsformat, err) ||
+ !ReadString(block_scope, "depsformat", &t.depsformat, err) ||
!ReadString(block_scope, "description", &t.description, err) ||
!ReadString(block_scope, "lib_dir_prefix", &t.lib_dir_prefix, err) ||
!ReadString(block_scope, "lib_prefix", &t.lib_prefix, err) ||
« no previous file with comments | « no previous file | tools/gn/ninja_toolchain_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698