Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 361503003: Rename GN tool's deps to depsformat. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
noelallen1
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Rename GN tool's deps to depsformat. This avoids collisions with the "deps" list of a toolchain. R=noelallen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M tools/gn/function_toolchain.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M tools/gn/ninja_toolchain_writer.cc View 1 chunk +4 lines, -1 line 0 comments Download
M tools/gn/toolchain.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 5 months ago (2014-06-27 21:06:02 UTC) #1
noelallen1
lgtm
6 years, 5 months ago (2014-06-30 17:04:17 UTC) #2
brettw
6 years, 5 months ago (2014-06-30 17:27:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r280619 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698