Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(49)

Issue 3615005: Language tag for speech prepatch (Closed)

Created:
9 years, 2 months ago by Leandro Graciá Gil
Modified:
8 years, 7 months ago
Reviewers:
Satish, jorlow
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

This is the first CL in a 4-sided patch to add language attribute support to speech input. The webkit change is at https://bugs.webkit.org/show_bug.cgi?id=47089 and will be submitted after this CL. Once the webkit change has been rolled into chromium DEPS the remaining chromium changes will be submitted by http://codereview.chromium.org/3595018/show . A last webkit patch will be submitted too to remove temporary fixes introduced to avoid test_shell breaking: https://bugs.webkit.org/show_bug.cgi?id=47420 . This patch implements the incoming changes in the WebKit::SpeechInputDispatcher interface. BUG=53598 TEST=none

Patch Set 1 #

Total comments: 7

Patch Set 2 : Code review fixes. #

Patch Set 3 : trying to fix a compile error. #

Patch Set 4 : changed 8-bit strings for UTF16 ones, language_tag is now named language. #

Total comments: 2

Patch Set 5 : Temporary fix in test_shell to avoid test breaks that could prevent updating WebKit. #

Patch Set 6 : test_shell changes reverted. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M chrome/renderer/speech_input_dispatcher.h View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/renderer/speech_input_dispatcher.cc View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Leandro Graciá Gil
Let's go with this before submitting the WebKit patch.
9 years, 2 months ago (2010-10-04 14:37:53 UTC) #1
Satish
On 2010/10/04 14:37:53, Leandro Graciá Gil wrote: > Let's go with this before submitting the ...
9 years, 2 months ago (2010-10-04 15:15:35 UTC) #2
Satish
http://codereview.chromium.org/3615005/diff/1/2 File chrome/renderer/speech_input_dispatcher.cc (right): http://codereview.chromium.org/3615005/diff/1/2#newcode36 chrome/renderer/speech_input_dispatcher.cc:36: // FIXME: preparing for a two-sided patch. remove this ...
9 years, 2 months ago (2010-10-04 15:16:47 UTC) #3
Satish
Also please use BUG=53598 for all major speech input CLs.
9 years, 2 months ago (2010-10-04 15:18:08 UTC) #4
Leandro Graciá Gil
Code review fixes and description update. http://codereview.chromium.org/3615005/diff/1/2 File chrome/renderer/speech_input_dispatcher.cc (right): http://codereview.chromium.org/3615005/diff/1/2#newcode36 chrome/renderer/speech_input_dispatcher.cc:36: // FIXME: preparing ...
9 years, 2 months ago (2010-10-06 15:38:50 UTC) #5
Leandro Graciá Gil
Compile error fixed. http://codereview.chromium.org/3615005/diff/1/3 File chrome/renderer/speech_input_dispatcher.h (right): http://codereview.chromium.org/3615005/diff/1/3#newcode33 chrome/renderer/speech_input_dispatcher.h:33: bool startRecognition(int request_id, const WebKit::WebCString& language_tag, ...
9 years, 2 months ago (2010-10-06 16:50:16 UTC) #6
Leandro Graciá Gil
Adding jorlow for review.
9 years, 2 months ago (2010-10-06 16:53:17 UTC) #7
Leandro Graciá Gil
On 2010/10/06 16:53:17, Leandro Graciá Gil wrote: > Adding jorlow for review. Adapting to recent ...
9 years, 2 months ago (2010-10-07 19:50:42 UTC) #8
Satish
LGTM http://codereview.chromium.org/3615005/diff/16001/17002 File chrome/renderer/speech_input_dispatcher.h (right): http://codereview.chromium.org/3615005/diff/16001/17002#newcode33 chrome/renderer/speech_input_dispatcher.h:33: // TODO(leandro): this is a temporary fix for ...
9 years, 2 months ago (2010-10-08 10:29:40 UTC) #9
Leandro Graciá Gil
Updated issue description with more details about the 4-sided patch. http://codereview.chromium.org/3615005/diff/16001/17002 File chrome/renderer/speech_input_dispatcher.h (right): http://codereview.chromium.org/3615005/diff/16001/17002#newcode33 ...
9 years, 2 months ago (2010-10-08 12:30:35 UTC) #10
Satish
9 years, 1 month ago (2010-10-13 16:01:39 UTC) #11
LGTM

Powered by Google App Engine
This is Rietveld 408576698