Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 361473002: Instrumented libraries: improve handling of custom patches. (Closed)

Created:
6 years, 5 months ago by earthdok
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Instrumented libraries: improve handling of custom patches. - pass the patch as a command line argument to the build script, instead of applying it through run_before_build, - add each patch and run_before_build script to inputs for its corresponding library, - move patches and scripts to their own subdirectories, - also, fix a small error in the build configuration for libappindicator1. BUG=313751 R=glider@chromium.org NOTRY=true TEST=compile Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280338

Patch Set 1 #

Patch Set 2 : use -i to pass filename to patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -245 lines) Patch
M third_party/instrumented_libraries/download_build_install.py View 1 2 chunks +9 lines, -2 lines 0 comments Download
D third_party/instrumented_libraries/freetype.sh View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/instrumented_libraries/instrumented_libraries.gyp View 10 chunks +15 lines, -10 lines 0 comments Download
D third_party/instrumented_libraries/libasound2.sh View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/instrumented_libraries/libcups2.diff View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/instrumented_libraries/libcups2.sh View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/instrumented_libraries/libfontconfig.diff View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/instrumented_libraries/libfontconfig.sh View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/instrumented_libraries/libgdk-pixbuf2.0-0.diff View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/instrumented_libraries/libgdk-pixbuf2.0-0.sh View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/instrumented_libraries/libgtk2.0-0.diff View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/instrumented_libraries/libgtk2.0-0.sh View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/instrumented_libraries/libnspr4.sh View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/instrumented_libraries/nss.diff View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/instrumented_libraries/nss.sh View 1 chunk +0 lines, -8 lines 0 comments Download
A + third_party/instrumented_libraries/patches/libcups2.diff View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/instrumented_libraries/patches/libfontconfig.diff View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/instrumented_libraries/patches/libgdk-pixbuf2.0-0.diff View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/instrumented_libraries/patches/libgtk2.0-0.diff View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/instrumented_libraries/patches/nss.diff View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/instrumented_libraries/patches/pulseaudio.diff View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/instrumented_libraries/patches/zlib1g.diff View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/instrumented_libraries/pulseaudio.diff View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/instrumented_libraries/pulseaudio.sh View 1 chunk +0 lines, -12 lines 0 comments Download
A + third_party/instrumented_libraries/scripts/freetype.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/instrumented_libraries/scripts/libasound2.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/instrumented_libraries/scripts/libgdk-pixbuf2.0-0.sh View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/instrumented_libraries/scripts/libgtk2.0-0.sh View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/instrumented_libraries/scripts/libnspr4.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/instrumented_libraries/scripts/pulseaudio.sh View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/instrumented_libraries/standard_instrumented_package_target.gypi View 2 chunks +14 lines, -1 line 0 comments Download
D third_party/instrumented_libraries/zlib1g.diff View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/instrumented_libraries/zlib1g.sh View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
earthdok
6 years, 5 months ago (2014-06-27 15:41:26 UTC) #1
Alexander Potapenko
On 2014/06/27 15:41:26, earthdok wrote: LGTM (comments discussed offline)
6 years, 5 months ago (2014-06-27 15:49:30 UTC) #2
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 5 months ago (2014-06-27 15:49:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/361473002/20001
6 years, 5 months ago (2014-06-27 15:50:37 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 15:51:58 UTC) #5
Message was sent while issue was closed.
Change committed as 280338

Powered by Google App Engine
This is Rietveld 408576698