Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 361443002: Avoid leaking a shared worker global scope on a failed script load. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
Reviewers:
tkent, horo
CC:
blink-reviews, haraken, kinuko
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Avoid leaking a shared worker global scope on a failed script load. The spec tells us, http://whatwg.org/specs/web-apps/current-work/#run-a-worker that in case of failure to load the script of a (shared) worker, we should report the failure and abort (step 4.) The global scope's closing flag will be left as false, meaning that we can safely shut down and destroy the shared worker global scope. Do so. R= BUG=364390 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177178

Patch Set 1 #

Patch Set 2 : No need to prematurely clear loader #

Patch Set 3 : Avoid deleting a terminating WebSharedWorkerImpl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M Source/web/WebSharedWorkerImpl.cpp View 1 2 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sof
Please take a look.
6 years, 5 months ago (2014-06-27 14:56:03 UTC) #1
sof
On 2014/06/27 14:56:03, sof wrote: > Please take a look. Seeing one or two flaky ...
6 years, 5 months ago (2014-06-28 06:16:45 UTC) #2
sof
On 2014/06/28 06:16:45, sof wrote: > On 2014/06/27 14:56:03, sof wrote: > > Please take ...
6 years, 5 months ago (2014-06-28 15:05:33 UTC) #3
sof
On 2014/06/28 15:05:33, sof wrote: ... > > (The tree is currently broken, so not ...
6 years, 5 months ago (2014-06-28 19:51:19 UTC) #4
horo
LGTM Thank you for fixing this.
6 years, 5 months ago (2014-06-30 01:16:21 UTC) #5
tkent
rslgtm
6 years, 5 months ago (2014-06-30 01:17:04 UTC) #6
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 5 months ago (2014-06-30 01:17:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/361443002/40001
6 years, 5 months ago (2014-06-30 01:17:57 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 02:03:23 UTC) #9
Message was sent while issue was closed.
Change committed as 177178

Powered by Google App Engine
This is Rietveld 408576698