Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: include/utils/SkCondVar.h

Issue 361423003: Add thread safety configuration check. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/utils/SkCondVar.h
diff --git a/include/utils/SkCondVar.h b/include/utils/SkCondVar.h
index 861a2aba8a057341d26f65110d8711daf7c50585..6f18e1a651df9e0443d00f1a6f3ba9ae9461e5c9 100644
--- a/include/utils/SkCondVar.h
+++ b/include/utils/SkCondVar.h
@@ -8,10 +8,20 @@
#ifndef SkCondVar_DEFINED
#define SkCondVar_DEFINED
+/**
+ * Import any thread model setting from configuration files.
reed1 2014/07/08 13:19:55 Does this comment belong here, or above <pthread.h
scroggo 2014/07/08 13:23:44 The include of SkTypes.h is to make sure that SK_U
+ */
+#include "SkTypes.h"
+
#ifdef SK_USE_POSIX_THREADS
#include <pthread.h>
#elif defined(SK_BUILD_FOR_WIN32)
#include <windows.h>
+#else
+/**
+ * Warn if the implementation of this class is empty, i.e. thread safety is not working.
+ */
+#warning "Thread safety class SkCondVar has no implementation!"
#endif
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698