Issue 361403006: Adding 64 bit checks

Issue 361403006: Adding 64 bit checks (Closed)

Created:
6 years, 5 months ago by sugoi1

Modified:
6 years, 5 months ago

Reviewers:
Stephen White, senorblanco, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Adding 64 bit checks Added a few more checks to avoid overflowing 32 bit sizes while computing convolutions. I also changed a dangerously misleading INHERITED typedef. BUG=389570 Committed: https://skia.googlesource.com/skia/+/c197c8a47eb9cf09b389f4dd5d235510feec18cb

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -3 lines)			Patch
M	src/core/SkConvolver.cpp	View	1 chunk	+1 line, -1 line	1 comment	Download
M	src/core/SkScaledImageCache.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/effects/SkColorMatrixFilter.cpp	View	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/361403006/1

6 years, 5 months ago (2014-07-03 17:32:13 UTC) #4

commit-bot: I haz the power

Change committed as c197c8a47eb9cf09b389f4dd5d235510feec18cb

6 years, 5 months ago (2014-07-03 17:44:30 UTC) #5

reed1

https://codereview.chromium.org/361403006/diff/1/src/core/SkConvolver.cpp File src/core/SkConvolver.cpp (right): https://codereview.chromium.org/361403006/diff/1/src/core/SkConvolver.cpp#newcode462 src/core/SkConvolver.cpp:462: unsigned char* curOutputRow = &output[(uint64_t)outY * outputByteRowStride]; future note: ...

6 years, 5 months ago (2014-07-07 13:16:40 UTC) #6

sugoi

6 years, 5 months ago (2014-07-07 14:06:36 UTC) #7

Message was sent while issue was closed.

On 2014/07/07 13:16:40, reed1 wrote:
> https://codereview.chromium.org/361403006/diff/1/src/core/SkConvolver.cpp
> File src/core/SkConvolver.cpp (right):
> 
>
https://codereview.chromium.org/361403006/diff/1/src/core/SkConvolver.cpp#new...
> src/core/SkConvolver.cpp:462: unsigned char* curOutputRow =
> &output[(uint64_t)outY * outputByteRowStride];
> future note: sk_64_mul() was written to for this sort of thing.

Noted, I'll replace them if I need to touch this code again.

Expand Messages | Collapse Messages