components: Add bookmarks to GN build.

components: Add bookmarks to GN build.

Splits components/translate per directory.

BUG=None
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn
R=ajwong@chromium.org
TBR=jochen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282561

[tfarina, 2014-07-03 00:45:18]

Sylvain, fyi the components/bookmarks/ gn stuff I told you I was going to add.

[tfarina, 2014-07-04 00:06:19]

Dirk, does this bot have xrandr installed?

The error says it cannot find -lxrandr.

Albert, could you review this while Brett is out for a few days?

Today I have landed a series of CLs, four, that fixed the link errors found in
patch set 1.

[tfarina, 2014-07-04 00:07:54]

Properly Dirk, and adding Brett to CC list.

[awong, 2014-07-07 21:52:12]

https://codereview.chromium.org/361373002/diff/160001/components/translate/co...
File components/translate/core/browser/BUILD.gn (right):

https://codereview.chromium.org/361373002/diff/160001/components/translate/co...
components/translate/core/browser/BUILD.gn:42: # TODO(brettw) move thise above.
This project uses net headers. This is
nit: thise -> these

https://codereview.chromium.org/361373002/diff/160001/ui/shell_dialogs/BUILD.gn
File ui/shell_dialogs/BUILD.gn (right):

https://codereview.chromium.org/361373002/diff/160001/ui/shell_dialogs/BUILD....
ui/shell_dialogs/BUILD.gn:61: #if (is_android && !android_webview_build) {
Why are these commented out?

[tfarina, 2014-07-09 01:43:43]

I will remove the shell_dialogs part for now as I haven't figure out the xrandr
problem yet.

https://codereview.chromium.org/361373002/diff/160001/ui/shell_dialogs/BUILD.gn
File ui/shell_dialogs/BUILD.gn (right):

https://codereview.chromium.org/361373002/diff/160001/ui/shell_dialogs/BUILD....
ui/shell_dialogs/BUILD.gn:61: #if (is_android && !android_webview_build) {
On 2014/07/07 21:52:12, awong wrote:
> Why are these commented out?

Because we don't have their deps yet.

[awong, 2014-07-09 01:49:40]

https://codereview.chromium.org/361373002/diff/160001/ui/shell_dialogs/BUILD.gn
File ui/shell_dialogs/BUILD.gn (right):

https://codereview.chromium.org/361373002/diff/160001/ui/shell_dialogs/BUILD....
ui/shell_dialogs/BUILD.gn:61: #if (is_android && !android_webview_build) {
On 2014/07/09 01:43:42, tfarina wrote:
> On 2014/07/07 21:52:12, awong wrote:
> > Why are these commented out?
> 
> Because we don't have their deps yet.

Can we only comment out the single line in the deps and mark with a TODO(GYP)? 
The //ui/android:ui_java looks close already.

[tfarina, 2014-07-09 01:59:02]

https://codereview.chromium.org/361373002/diff/160001/ui/shell_dialogs/BUILD.gn
File ui/shell_dialogs/BUILD.gn (right):

https://codereview.chromium.org/361373002/diff/160001/ui/shell_dialogs/BUILD....
ui/shell_dialogs/BUILD.gn:61: #if (is_android && !android_webview_build) {
On 2014/07/09 01:49:40, awong wrote:
> On 2014/07/09 01:43:42, tfarina wrote:
> > On 2014/07/07 21:52:12, awong wrote:
> > > Why are these commented out?
> > 
> > Because we don't have their deps yet.
> 
> Can we only comment out the single line in the deps and mark with a TODO(GYP)?

> The //ui/android:ui_java looks close already.
We can, but I will do it in a separate patch when I figure out the following
error:

FAILED: g++ -Wl,--fatal-warnings -m64 -fPIC -Wl,-z,noexecstack -Wl,-z,now
-Wl,-z,relro -B../../third_party/binutils/Linux_x64/Release/bin -Wl,--icf=none
-pthread -Wl,-O1 -Wl,--as-needed -Wl,--gc-sections -Wl,-rpath=\\\$ORIGIN/lib/
-Wl,-rpath-link=lib/ -o shell_dialogs_unittests -Wl,--start-group
@shell_dialogs_unittests.rsp  -Wl,--end-group  -ldl -lgmodule-2.0 -lgobject-2.0
-lgthread-2.0 -lrt -lglib-2.0 -lfontconfig -lfreetype -lpangocairo-1.0
-lpango-1.0 -lcairo -lX11 -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi
-lXrender -lXss -lXtst -lgconf-2 -lresolv -lnss3 -lnssutil3 -lsmime3 -lplds4
-lplc4 -lnspr4 -lxrandr 
../../third_party/binutils/Linux_x64/Release/bin/ld: error: cannot find -lxrandr

[tfarina, 2014-07-09 02:04:18]

ui/shell_dialogs removed.

[tfarina, 2014-07-09 02:05:14]

https://codereview.chromium.org/361373002/diff/160001/components/translate/co...
File components/translate/core/browser/BUILD.gn (right):

https://codereview.chromium.org/361373002/diff/160001/components/translate/co...
components/translate/core/browser/BUILD.gn:42: # TODO(brettw) move thise above.
This project uses net headers. This is
On 2014/07/07 21:52:12, awong wrote:
> nit: thise -> these

Done.

[tfarina, 2014-07-09 22:08:52]

Albert, Brett? Ping?

[awong, 2014-07-09 22:41:58]

LGTM

[tfarina, 2014-07-10 16:30:27]

TBRing Jochen for chrome/ and components/

[tfarina, 2014-07-10 16:30:33]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-07-10 16:31:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/361373002/200001

[commit-bot: I haz the power, 2014-07-10 16:44:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/27063)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/31497)

[commit-bot: I haz the power, 2014-07-10 16:46:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-10 16:46:33]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/27068)

[tfarina, 2014-07-11 00:47:44]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-07-11 00:49:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/361373002/220001

[tfarina, 2014-07-11 01:12:46]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-07-11 01:15:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/361373002/240001

[commit-bot: I haz the power, 2014-07-11 07:00:56]

Change committed as 282561