Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 361283002: StyleDifference should store property-specific difference in a bit field (Closed)

Created:
6 years, 5 months ago by abarth-chromium
Modified:
6 years, 5 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

StyleDifference should store property-specific difference in a bit field This CL prepares us for adding a hasOnlyPropertySpecificDifference function in a future CL that operates on all the property-specific differences as a unit. R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M Source/core/rendering/style/StyleDifference.h View 3 chunks +22 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
abarth-chromium
6 years, 5 months ago (2014-07-02 16:49:12 UTC) #1
eseidel
lgtm Please fix your description to say that it's not about simplifying (I argue this ...
6 years, 5 months ago (2014-07-02 16:56:41 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 5 months ago (2014-07-02 16:58:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/361283002/1
6 years, 5 months ago (2014-07-02 17:00:07 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-02 18:05:11 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 18:51:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/15125)
6 years, 5 months ago (2014-07-02 18:51:07 UTC) #7
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 5 months ago (2014-07-02 19:27:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/361283002/1
6 years, 5 months ago (2014-07-02 19:28:33 UTC) #9
abarth-chromium
6 years, 5 months ago (2014-07-02 20:30:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 manually as r177417 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698