Issue 361253004: Add compiling chrome/browser to GN build on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 361253004: Add compiling chrome/browser to GN build on Linux. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
awong

CC:
chromium-reviews, cbentzel+watch_chromium.org, browser-components-watch_chromium.org, kinuko+fileapi, nhiroki, tzik

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Add compiling chrome/browser to GN build on Linux. This does not link but all files compile now. Mostly this patch adds missing protobug dependencies. R=ajwong@chromium.org TBR=ajwong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281825

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -28 lines)			Patch
M	chrome/app/resources/BUILD.gn	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/BUILD.gn	View		8 chunks	+11 lines, -13 lines	0 comments	Download
A +	chrome/browser/history/BUILD.gn	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/net/BUILD.gn	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A +	chrome/browser/sync_file_system/BUILD.gn	View		1 chunk	+3 lines, -5 lines	0 comments	Download
A +	chrome/browser/sync_file_system/drive_backend/BUILD.gn	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4	7 chunks	+14 lines, -4 lines	0 comments	Download
M	chrome/chrome_resources.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

brettw

6 years, 5 months ago (2014-07-08 21:10:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r281825 (presubmit successful).