Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: net/quic/crypto/p256_key_exchange.h

Issue 361193003: Eliminate ScopedOpenSSL in favour of scoped_ptr<> specializations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/quic/crypto/channel_id_openssl.cc ('k') | net/quic/crypto/p256_key_exchange_openssl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_CRYPTO_P256_KEY_EXCHANGE_H_ 5 #ifndef NET_QUIC_CRYPTO_P256_KEY_EXCHANGE_H_
6 #define NET_QUIC_CRYPTO_P256_KEY_EXCHANGE_H_ 6 #define NET_QUIC_CRYPTO_P256_KEY_EXCHANGE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "base/strings/string_piece.h" 11 #include "base/strings/string_piece.h"
12 #include "net/base/net_export.h" 12 #include "net/base/net_export.h"
13 #include "net/quic/crypto/key_exchange.h" 13 #include "net/quic/crypto/key_exchange.h"
14 14
15 #if defined(USE_OPENSSL) 15 #if defined(USE_OPENSSL)
16 #include "crypto/openssl_util.h" 16 #include "crypto/openssl_util.h"
17 // Forward declaration for openssl/*.h 17 #include "crypto/scoped_openssl_types.h"
18 typedef struct ec_key_st EC_KEY;
19 extern "C" void EC_KEY_free(EC_KEY* key);
20 #else 18 #else
21 #include "crypto/ec_private_key.h" 19 #include "crypto/ec_private_key.h"
22 #include "crypto/scoped_nss_types.h" 20 #include "crypto/scoped_nss_types.h"
23 #endif 21 #endif
24 22
25 namespace net { 23 namespace net {
26 24
27 // P256KeyExchange implements a KeyExchange using elliptic-curve 25 // P256KeyExchange implements a KeyExchange using elliptic-curve
28 // Diffie-Hellman on NIST P-256. 26 // Diffie-Hellman on NIST P-256.
29 class NET_EXPORT_PRIVATE P256KeyExchange : public KeyExchange { 27 class NET_EXPORT_PRIVATE P256KeyExchange : public KeyExchange {
(...skipping 26 matching lines...) Expand all
56 kUncompressedP256PointBytes = 1 + 2 * kP256FieldBytes, 54 kUncompressedP256PointBytes = 1 + 2 * kP256FieldBytes,
57 // The first byte in an uncompressed P-256 point. 55 // The first byte in an uncompressed P-256 point.
58 kUncompressedECPointForm = 0x04, 56 kUncompressedECPointForm = 0x04,
59 }; 57 };
60 58
61 #if defined(USE_OPENSSL) 59 #if defined(USE_OPENSSL)
62 // P256KeyExchange takes ownership of |private_key|, and expects 60 // P256KeyExchange takes ownership of |private_key|, and expects
63 // |public_key| consists of |kUncompressedP256PointBytes| bytes. 61 // |public_key| consists of |kUncompressedP256PointBytes| bytes.
64 P256KeyExchange(EC_KEY* private_key, const uint8* public_key); 62 P256KeyExchange(EC_KEY* private_key, const uint8* public_key);
65 63
66 crypto::ScopedOpenSSL<EC_KEY, EC_KEY_free> private_key_; 64 crypto::ScopedEC_KEY private_key_;
67 #else 65 #else
68 // P256KeyExchange takes ownership of |key_pair|, and expects 66 // P256KeyExchange takes ownership of |key_pair|, and expects
69 // |public_key| consists of |kUncompressedP256PointBytes| bytes. 67 // |public_key| consists of |kUncompressedP256PointBytes| bytes.
70 P256KeyExchange(crypto::ECPrivateKey* key_pair, const uint8* public_key); 68 P256KeyExchange(crypto::ECPrivateKey* key_pair, const uint8* public_key);
71 69
72 scoped_ptr<crypto::ECPrivateKey> key_pair_; 70 scoped_ptr<crypto::ECPrivateKey> key_pair_;
73 #endif 71 #endif
74 // The public key stored as an uncompressed P-256 point. 72 // The public key stored as an uncompressed P-256 point.
75 uint8 public_key_[kUncompressedP256PointBytes]; 73 uint8 public_key_[kUncompressedP256PointBytes];
76 74
77 DISALLOW_COPY_AND_ASSIGN(P256KeyExchange); 75 DISALLOW_COPY_AND_ASSIGN(P256KeyExchange);
78 }; 76 };
79 77
80 } // namespace net 78 } // namespace net
81 #endif // NET_QUIC_CRYPTO_P256_KEY_EXCHANGE_H_ 79 #endif // NET_QUIC_CRYPTO_P256_KEY_EXCHANGE_H_
82 80
OLDNEW
« no previous file with comments | « net/quic/crypto/channel_id_openssl.cc ('k') | net/quic/crypto/p256_key_exchange_openssl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698